Let BarcodeScannerView manage lifecycle event. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eEventListener in createViewInstance and remove LifecycleEventListener in onDropViewInstance.
|
@zongjingyao thank you for your contribution. could you provide some more details about the motivations for your pull request. did you encounter any problems with the former approach? |
|
Does this solve the camera 'lock' issue? When developing with hot reload, after first reload the emulator crashes. Need to activate/deactivate with another app (e.g. skype) to be able to re-run my script. |
andreaskeller
force-pushed
the
master
branch
2 times, most recently
from
b0333a4 to
66c948c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let BarcodeScannerView implements LifecycleEventListener. Add LifecycleEventListener in createViewInstance and remove LifecycleEventListener in onDropViewInstance.