Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more checks in periodic boundary conditions #29124

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

GiudGiud
Copy link
Contributor

@GiudGiud GiudGiud commented Nov 22, 2024

I was debugging an input with PBCs for #29051 and this pushed me to add code to help address #22496

should be ready unless there are some ill-formed inputs out there

@GiudGiud GiudGiud self-assigned this Nov 22, 2024
@GiudGiud GiudGiud marked this pull request as ready for review November 22, 2024 23:59
@moosebuild
Copy link
Contributor

moosebuild commented Nov 23, 2024

Job Documentation, step Docs: sync website on 739a663 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Nov 23, 2024

Job Coverage, step Generate coverage on 739a663 wanted to post the following:

Framework coverage

8a5faa #29124 739a66
Total Total +/- New
Rate 85.14% 85.14% +0.00% 90.00%
Hits 107324 107349 +25 36
Misses 18727 18731 +4 4

Diff coverage report

Full coverage report

Modules coverage

Stochastic tools

8a5faa #29124 739a66
Total Total +/- New
Rate 90.67% 90.69% +0.02% -
Hits 8110 8112 +2 0
Misses 835 833 -2 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

test/tests/bcs/periodic/tests Outdated Show resolved Hide resolved
test/tests/bcs/periodic/tests Outdated Show resolved Hide resolved
- improve tests detail formatting

Co-authored-by: Alex Lindsay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants