Remove linking warning from gfortran + clang #29010
Conversation
framework/moose.mk
Outdated
| @@ -424,7 +424,7 @@ $(hit_LIB): $(hit_objects) | |||
| $(moose_LIB): $(moose_objects) $(pcre_LIB) $(gtest_LIB) $(hit_LIB) $(pyhit_LIB) | |||
| @echo "Linking Library "$@"..." | |||
| @$(libmesh_LIBTOOL) --tag=CXX $(LIBTOOLFLAGS) --mode=link --quiet \ | |||
| $(libmesh_CXX) $(CXXFLAGS) $(libmesh_CXXFLAGS) -o $@ $(moose_objects) $(pcre_LIB) $(png_LIB) $(libmesh_LDFLAGS) $(libmesh_LIBS) $(EXTERNAL_FLAGS) -rpath $(FRAMEWORK_DIR) | |||
| $(libmesh_CXX) $(CXXFLAGS) $(libmesh_CXXFLAGS) -o $@ $(moose_objects) $(pcre_LIB) $(png_LIB) $(libmesh_LDFLAGS) $(libmesh_LIBS) $(EXTERNAL_FLAGS) -rpath $(FRAMEWORK_DIR) 2>&1 | grep -v "ld: warning: could not create compact unwind for" | grep -v "could not create compact unwind for" | |||
There was a problem hiding this comment.
Do we want to put this inside a if darwin?
There was a problem hiding this comment.
we d need to duplicate that line though? maybe sending that line through a function to do this cleaning up
|
Still seeing some of this warnings possibly because I am compiling Griffin? |
|
yes you d need to use this "grep" in app.mk too. |
|
This fix looks pretty horrible. Does not work? |
GiudGiud
force-pushed
the
PR_warn_macos
branch
from
8ce00f8
to
33b9656
Compare
|
Yeah, we definitely don't want to pipe all stderr to stdout. Those need to remain separate |
|
see this post Disables exception handling from what I understood |
|
So we cant grep on stderr (which I why I redirected) but maybe there is another way to filter it. I ll take a look |
GiudGiud
force-pushed
the
PR_warn_macos
branch
from
33b9656
to
9def55d
Compare
But it doesn't work anyways when the warning is issued! Might as well disable it then on that architecture... |
|
it does not work for the routines that it reports a warning for. if you pass the flag, it will disable it for everything |
|
From the looks of the names in the warnings those seem to be fortran functions. Could we add the flag selectively? |
|
lemme try |
|
There isnt a separate command for linking code from fortran source though? |
closes #29009
The fix looks a little weird, but it's needed on my machine because the output from linking is somewhat garbled
Feel free to try out your proposed solutions locally