Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various SQA improvements #107

Merged
merged 14 commits into from
Oct 17, 2023
Merged

Various SQA improvements #107

merged 14 commits into from
Oct 17, 2023

Conversation

cticenhour
Copy link
Member

Refs #73

@cticenhour cticenhour self-assigned this Oct 5, 2023
@cticenhour cticenhour mentioned this pull request Oct 5, 2023
Open
31 tasks
@cticenhour cticenhour force-pushed the sqa-work-24 branch 2 times, most recently from e9dfdae to 747c5b9 Compare October 10, 2023 21:58
@cticenhour cticenhour marked this pull request as ready for review October 10, 2023 21:58
@cticenhour cticenhour changed the title [WIP] Various SQA improvements Various SQA improvements Oct 10, 2023
@moosebuild
Copy link

moosebuild commented Oct 10, 2023 •
edited
Loading

Job Documentation on 6f7c698 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

moosebuild commented Oct 10, 2023 •
edited
Loading

Job Coverage on 6f7c698 wanted to post the following:

Coverage

417cd5 #107 6f7c69
Total Total +/- New
Rate 70.01% 69.71% -0.30% 0.00%
Hits 976 976 - 0
Misses 418 424 +6 173

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 0.00% is less than the suggested 90.0%

This comment will be updated on new commits.

@cticenhour
SQA: add user manual link to syntax index, disable theory manual chec…
b6ee71a 
…k and add reason

Refs idaholab#73
@cticenhour
SQA: fixup top level requirement detail warning
ce529a5 
Refs idaholab#73
@cticenhour
SQA: add missing issue numbers
179381d 
Refs idaholab#73
@cticenhour
SQA: set all warnings as errors
1d87e1e 
Refs idaholab#73
@cticenhour
SQA: Fixup deprecated 'requirements_traceability_matrix' document nam…
776100b 
…e in sqa_reports.yml

Refs idaholab#73
@cticenhour
SQA: add missing class descriptions
c20a85c 
Refs idaholab#73
@cticenhour
SQA: fixup documentation stubs
4daaacd 
Refs idaholab#73
@cticenhour
SQA: fixup duplicate requirements in gaussian heat source tests
5da87ef 
Refs idaholab#73
@cticenhour
SQA: skip malamute/examples for requirements/design checks for now
f95271f 
It should be added back in when the examples selection is more stable and less R&D

Refs idaholab#73
@moosebuild
Copy link

Job Mac Test on f95271f : invalidated by @cticenhour

@sapitts
Copy link
Collaborator

sapitts commented Oct 12, 2023

Is there a way to get a MALAMUTE-only set of documentation? It's not as straight forward to review the rendered documentation pages as lazy-me would like

@cticenhour
Copy link
Member Author

MALAMUTE-only syntax is now available in 1cb748e.

sapitts
sapitts requested changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@sapitts sapitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identified some small issues that would be nice to clean up during this merge request

doc/content/source/bcs/DisplaceBoundaryBC.md Outdated Show resolved Hide resolved
doc/content/sqa/user_manual.md Show resolved Hide resolved
src/kernels/ADStressDivergence.C Outdated Show resolved Hide resolved
src/materials/CrazyKCPlantFits.C Outdated Show resolved Hide resolved
src/materials/CrazyKCPlantFitsBoundary.C Outdated Show resolved Hide resolved
examples/sps/engineering_scale/validation/dcs5/empty_die/stepped_20mm/tests Outdated Show resolved Hide resolved
src/indicators/AbsoluteValueIndicator.C Outdated Show resolved Hide resolved
test/tests/gaussian_heat_source/tests Outdated Show resolved Hide resolved
test/tests/gaussian_heat_source/tests Outdated Show resolved Hide resolved
test/tests/gaussian_heat_source/tests Outdated Show resolved Hide resolved
@moosebuild
Copy link

Job Precheck on 3847c57 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/malamute/docs/PRs/107/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 2f67b933ab4d78a4f2df206dba4722c71b7efe7a

@cticenhour cticenhour mentioned this pull request Oct 17, 2023
Open
@sapitts sapitts merged commit c1c3c4e into idaholab:devel Oct 17, 2023
8 checks passed
@cticenhour cticenhour deleted the sqa-work-24 branch October 17, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindsayad lindsayad lindsayad left review comments

@sapitts sapitts sapitts approved these changes

Assignees

@cticenhour cticenhour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cticenhour @moosebuild @sapitts @lindsayad