Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mat redesign #507

Draft
wants to merge 273 commits into
base: alpha-test-dev
Choose a base branch
from
Draft

Mat redesign #507

wants to merge 273 commits into from

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Aug 25, 2024

Description

Please include a summary of the change and which issue is fixed if applicable. Please also include relevant motivation and context.

Design based on #475.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Implement alpha deploy process to PyPI in GHA
  • Test that Element and Nucleus? are immutable.
  • Added versionadded and versionchanged
  • Test unruly strings for material printing
  • test set like behavior for numberedobject collection
  • promote surfaces to be second or first class objects.
  • test materials with plib intermixed with materials
  • document migration.
  • Create easy way to edit existing Nuclide definition (library), and fraction.
  • Document all random constant dictionaries in dev stuff, and add to PR checklist
  • Implement all proposed changes from RFI: Overhauling how Materials and Isotopes are handled. #475.
  • Manually merge due to immediate deploy
  • Cleat out all TODOs
  • Document that type strings are now the standard going forward. Mention rolling basis. Mention pytest expectations.

@MicahGale MicahGale added alpha testing Issues that came up during alpha testing bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". code improvement A feature request that will improve the software and its maintainability, but be invisible to users. labels Aug 25, 2024
@MicahGale MicahGale self-assigned this Sep 4, 2024
@MicahGale MicahGale marked this pull request as ready for review September 11, 2024 18:11
@MicahGale MicahGale marked this pull request as draft September 11, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha testing Issues that came up during alpha testing bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". code improvement A feature request that will improve the software and its maintainability, but be invisible to users. feature request An issue that improves the user interface. parsers are hard Examples of where MCNP syntax is complicated and should be simplified.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant