This repository has been archived by the owner on Sep 24, 2020. It is now read-only.
Created unit test for Windows-only resolver bug. #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume on Windows, you load the MS.NET reference assemblies? |
|
I'm using .NET on Windows and Mono on Ubuntu. I haven't installed Mono on Windows. Visual Studio correctly resolves precedent to Also, I find it highly suspicious that removing the IsFaulted line can change the chosen overload. Either way, this is what I get (Windows results obtained with VS debugger, Linux results with MD). Test program: [Test]
public void LambdaTaskParameterTest()
{
string program = @"using System.Threading.Tasks;
class TestClass {
public void TestMethod () {
Task<int> foo = null;
$foo.ContinueWith$(precedent => {
//Console.WriteLine (precedent.IsFaulted);
});
}
}";
var resolveResult = Resolve<MethodGroupResolveResult>(program);
} //Insert breakpoint hereOn Windows NRefactory, the MethodGroupResolveResult of ContinueWith gives me 40 methods (0 extension methods, 2 method lists with 20 methods each). NRefactory on Linux also gives me 40 methods, in 2 method lists: Method list 2: |
|
I've checked the resolve result of the whole invocation ( Windows (with the IsFaulted line): Windows (without the IsFaulted line): Linux: So that pretty much confirms NRefactory is picking the wrong overload of ContinueWith on Windows. |
|
Here's the full resolver log: https://gist.github.com/dgrunwald/7442645 Note that |
|
Confirmed. Adding Still, I wonder why NRefactory on Linux recovers from this error when NRefactory on Windows fails. |
|
On Linux, this is the resolver log: https://gist.github.com/luiscubal/7548131 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an unit test for a resolver bug that happens only on Windows (see #359).
Note that the resolver decides that precedent is of type
Task, notTask<int>but only on Windows. On Ubuntu, it correctly guesses the type of the precedent task.For extra weirdness, comment the
Console.WriteLine (precedent.IsFaulted);line. Note that the bug will go away.Disclaimer: I'm not 100% sure my Windows and Linux systems are running the same IKVM/Cecil versions.