Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks Claudio for merging.
Rechecking, I found these typos in README.md.
Also, do you think setting a flash variable is the best way to force a permission dialog? The alternative is to add a parameter to the auth URL. e.g.
/auth/spotify/?show_dialog=true
.These auth parameters are usually used to carry an application state through the authorization sequence on the redirect URL. However Spotify is one provider that requires the redirect URL sent in the request and callback phases to exactly match, including the query string, so this gem's code doesn't include any auth parameters in the callback URL it sends. This makes auth parameters available to be used for another purpose, such as for additional authentication request parameters. So there's a trade-off between the neatness and framework-independence of the parameter approach and this approach's non-standard use of the auth query string.