Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in README.md #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typo in README.md #13

wants to merge 1 commit into from

Conversation

mrj
Copy link
Contributor

@mrj mrj commented Feb 17, 2017

Thanks Claudio for merging.

Rechecking, I found these typos in README.md.

Also, do you think setting a flash variable is the best way to force a permission dialog? The alternative is to add a parameter to the auth URL. e.g. /auth/spotify/?show_dialog=true.

These auth parameters are usually used to carry an application state through the authorization sequence on the redirect URL. However Spotify is one provider that requires the redirect URL sent in the request and callback phases to exactly match, including the query string, so this gem's code doesn't include any auth parameters in the callback URL it sends. This makes auth parameters available to be used for another purpose, such as for additional authentication request parameters. So there's a trade-off between the neatness and framework-independence of the parameter approach and this approach's non-standard use of the auth query string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant