-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up the read module after adding cloud-read capabilities #502
Conversation
👈 Launch a binder notebook on this branch for commit 2ba4cd3 I will automatically update this comment whenever this PR is modified 👈 Launch a binder notebook on this branch for commit 420acb3 👈 Launch a binder notebook on this branch for commit 487f5a5 👈 Launch a binder notebook on this branch for commit 737005a 👈 Launch a binder notebook on this branch for commit 86a4ad7 👈 Launch a binder notebook on this branch for commit 734a55e 👈 Launch a binder notebook on this branch for commit db4ccdb 👈 Launch a binder notebook on this branch for commit 8fa662d 👈 Launch a binder notebook on this branch for commit a9a46c5 👈 Launch a binder notebook on this branch for commit 8cb9cd9 👈 Launch a binder notebook on this branch for commit c7cc03e 👈 Launch a binder notebook on this branch for commit 839d433 👈 Launch a binder notebook on this branch for commit f8b7f0b |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development #502 +/- ##
===============================================
+ Coverage 66.05% 66.10% +0.04%
===============================================
Files 36 36
Lines 3111 3062 -49
Branches 552 540 -12
===============================================
- Hits 2055 2024 -31
+ Misses 963 947 -16
+ Partials 93 91 -2 ☔ View full report in Codecov by Sentry. |
@rwegener2 What are the odds you'd have a few moments in the next couple of weeks to review this PR? The diff is slightly confusing based on how GH is formatting it, but the commit messages are a pretty clear list of what's happening for navigation. I may add some more linting fixes before it's merged, but they should only be making long lines shorter so won't change the content. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wooohooo for removing unneeded code! Nice PR, @JessicaS11!
I made two changes but I think they're pretty small - one was a syntax error in the existing code I found in is2ref.py. The other was related to the comment you left about checking if 0 products are found in the product list.
In getting to release of v1.0.0 and getting the functionality of cloud reading in (e.g. #438, #468), we ended up with a few deprecated functions in the read module. This PR removes those and moves some of the input parsing/checking for read into a standalone function that's now tested.