Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codecov uploader to start getting coverage reports #496

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

JessicaS11
Copy link
Member

@JessicaS11 JessicaS11 commented Jan 18, 2024

At some point we stopped getting code testing coverage reports (it was failing silently in Travis CI). This PR updates to use the most recent uploader. Addresses #485.

References:

Copy link

Binder 👈 Launch a binder notebook on this branch for commit 9b45e9f

I will automatically update this comment whenever this PR is modified

@JessicaS11 JessicaS11 linked an issue Jan 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 254 lines in your changes are missing coverage. Please review.

Comparison is base (d9a9d94) 59.09% compared to head (9b45e9f) 66.09%.
Report is 44 commits behind head on development.

Files Patch % Lines
icepyx/core/read.py 26.59% 68 Missing and 1 partial ⚠️
icepyx/core/is2ref.py 32.72% 37 Missing ⚠️
icepyx/core/variables.py 26.82% 30 Missing ⚠️
icepyx/quest/dataset_scripts/argo.py 79.59% 22 Missing and 8 partials ⚠️
icepyx/quest/quest.py 49.09% 28 Missing ⚠️
icepyx/core/query.py 69.23% 13 Missing and 7 partials ⚠️
icepyx/core/auth.py 76.74% 7 Missing and 3 partials ⚠️
icepyx/core/temporal.py 91.30% 4 Missing and 4 partials ⚠️
icepyx/core/granules.py 22.22% 6 Missing and 1 partial ⚠️
icepyx/tests/test_behind_NSIDC_API_login.py 0.00% 7 Missing ⚠️
... and 4 more
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #496      +/-   ##
===============================================
+ Coverage        59.09%   66.09%   +7.00%     
===============================================
  Files               30       36       +6     
  Lines             2264     3115     +851     
  Branches           488      552      +64     
===============================================
+ Hits              1338     2059     +721     
- Misses             843      963     +120     
- Partials            83       93      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JessicaS11 JessicaS11 requested a review from weiji14 January 18, 2024 19:43
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply, was away for a few days. I see that the code is copied from the official instructions at https://docs.codecov.com/docs/codecov-uploader#integrity-checking-the-uploader, and the Codecov bot commented above, so should be all good!

@JessicaS11 JessicaS11 merged commit d89fb4b into development Jan 24, 2024
7 checks passed
@JessicaS11 JessicaS11 deleted the codecov branch January 24, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

figure out where the codecov reports went
2 participants