-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert deprecation warnings to errors #482
Conversation
👈 Launch a binder notebook on this branch for commit d04ea3d I will automatically update this comment whenever this PR is modified 👈 Launch a binder notebook on this branch for commit 585a815 👈 Launch a binder notebook on this branch for commit f450398 👈 Launch a binder notebook on this branch for commit 5bfd3b9 👈 Launch a binder notebook on this branch for commit 1d5d465 👈 Launch a binder notebook on this branch for commit 1fada73 👈 Launch a binder notebook on this branch for commit 6305372 👈 Launch a binder notebook on this branch for commit 192f107 👈 Launch a binder notebook on this branch for commit 06284c0 👈 Launch a binder notebook on this branch for commit 05d241a 👈 Launch a binder notebook on this branch for commit ed3abf3 👈 Launch a binder notebook on this branch for commit 706ffe6 👈 Launch a binder notebook on this branch for commit 94ab0ce 👈 Launch a binder notebook on this branch for commit c3eb899 👈 Launch a binder notebook on this branch for commit 49357be |
@rwegener2 This is basically ready for review, but I figured we'd want to merge #468 first since that's got some code changes in the same areas and there could be merge conflicts. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@rwegener2 This is all set for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I'm loving all that code in the Read init that can be eliminated. I had a few suggestions, but I had to commit them directly since Github doesn't let you suggest on un-modified code. I tried to make small descriptive commits so you can see what is changing but overall it was just small updates to deprecated docstrings and condensing the deprecation errors.
Nice PR! 🎉
Co-authored-by: Rachel Wegener <[email protected]>
Me too! Thanks for the edits. |
…482) Co-authored-by: Rachel Wegener <[email protected]>
icepyx has a series of deprecations that are still warnings. Some are new deprecations during the modifications for cloud reading, and some are stale but were never turned into errors prior to planned removal. This PR aims to turn all current deprecations into errors for the v1 release, with planned removal of the errors in a future minor release.