Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minor/patch release docs #472

Merged
merged 2 commits into from
Nov 15, 2023
Merged

add minor/patch release docs #472

merged 2 commits into from
Nov 15, 2023

Conversation

JessicaS11
Copy link
Member

release documents for v0.8.1 patch release once #470 is merged.

Copy link

github-actions bot commented Nov 14, 2023

Binder 👈 Launch a binder notebook on this branch for commit 380917c

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 31f4a20

Binder 👈 Launch a binder notebook on this branch for commit 2df2308

Base automatically changed from atl08-index to main November 14, 2023 19:57
@JessicaS11 JessicaS11 marked this pull request as ready for review November 14, 2023 19:58
@JessicaS11 JessicaS11 changed the base branch from main to development November 14, 2023 20:00
@JessicaS11 JessicaS11 changed the base branch from development to main November 14, 2023 20:00
@JessicaS11
Copy link
Member Author

Not sure why the readthedocs builds are hanging. I just triggered one manually for this branch; #470 (just merged) built successfully and never had the status update properly in the PR yesterday/today...

@rwegener2
Copy link
Contributor

Not sure why the readthedocs builds are hanging.

That is odd. I found an instance in the readthedocs GH issue history back in 2016 where the servers froze and someone had to go physically inspect to find the problem. I'm not sure if that could be happening here, too.

I have been able to keep working with a local install for the day. Maybe we leave it for a while and if it still isn't working in the morning submit an issue to readthedocs? Or we could just submit an issue now. 🤷🏻‍♀️

@JessicaS11
Copy link
Member Author

Maybe we leave it for a while and if it still isn't working in the morning submit an issue to readthedocs?

Ordinarily I'd be fine with that plan, but if we want the conda build to be picked up I'd prefer we have the release done tonight since it can take a few hours to get picked up by their bot. I'd have concerns that even if you're showing a pip install someone will try to conda install and then you'll have version issues during the tutorial.

@JessicaS11 JessicaS11 closed this Nov 14, 2023
@JessicaS11 JessicaS11 reopened this Nov 14, 2023
@JessicaS11
Copy link
Member Author

GitHub is getting a 400 from the readthedocs webhook with message {"detail":"Parameter \"ref\" is required"}. ref seems to be in some of the payloads submitted and not others (depending on the trigger type), but was not previously a problem (across trigger types). So right now pull_request.push triggers seem to be accepted by RTD, but other actions (e.g. pull_request.synchronize) are rejected.

@weiji14
Copy link
Member

weiji14 commented Nov 14, 2023

Seems like an issue with the GitHub webhook integration - readthedocs/readthedocs.org#10902? Looks like a fix is on the way.

@rwegener2
Copy link
Contributor

Good find @weiji14! It appears the issue was just resolved. I just re-pushed to trigger a build and the docs seem to have built properly. 🎉

@JessicaS11 JessicaS11 merged commit 6d7c170 into main Nov 15, 2023
2 of 3 checks passed
@JessicaS11 JessicaS11 deleted the v081patch branch November 15, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants