fix spot number calculation #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpswinski
approved these changes
Oct 17, 2023
JessicaS11
added a commit
that referenced
this pull request
Nov 15, 2023
--------- Co-authored-by: GitHub Action <[email protected]>
JessicaS11
added a commit
that referenced
this pull request
Jan 5, 2024
--------- Co-authored-by: GitHub Action <[email protected]>
JessicaS11
added a commit
that referenced
this pull request
Jan 5, 2024
This reverts commit 0591de2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent addressing of a dev note brought to light the fact that internal spot number calculations were incorrect. Further investigation showed that this was previously addressed in SlideRule (the function upon which the original icepyx implementation was based) and is now clearly displayed in a table in the ATL03 ATBD (p128), but the changes did not make it upstream into icepyx at the time the error was discovered. This PR updates the spot number calculation and adds a warning for users.