-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.8.0 #447
Release v0.8.0 #447
Conversation
Matches Release v0.6.4_JOSS per #420 plus a few editorial edits available via the pubs/joss branch. Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Tyler Sutterley <[email protected]> Co-authored-by: Romina Piunno <[email protected]> Co-authored-by: aaarendt <[email protected]> Co-authored-by: Kelsey Bisson <[email protected]> Co-authored-by: Zach Fair <[email protected]> Co-authored-by: liuzheng-arctic <[email protected]> Co-authored-by: Don Setiawan <[email protected]> Co-authored-by: Tian Li <[email protected]> Co-authored-by: Friedrich Knuth <[email protected]> Co-authored-by: Raphael Hagen <[email protected]> Co-authored-by: Shashank Bhushan <[email protected]> Co-authored-by: nitin-ravinder <[email protected]> Co-authored-by: learn2phoenix <[email protected]> Co-authored-by: Scott Henderson <[email protected]>
* add CITATION.cff file * update citation docs with Zenodo doi and 'icepyx Developers' as author Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Wei Ji <[email protected]>
* add s3fs as requirement to make cloud access default * transition to recommending mamba over conda
* add JOSS to bib and badges * switch zenodo links to nonversioned icepyx
* create temporal module * create temporal testing module * add support for more temporal input types (datetime objects) and formats (dict) * temporal docstring, user guide updates * updated example notebook for new temporal inputs * update temporal info in data access tutorial example notebook * GitHub action UML generation auto-update --------- Co-authored-by: sjh1024 <[email protected]> Co-authored-by: Jessica Scheick <[email protected]>
Always send CMR query to provider NSIDC_CPRD to make sure s3 urls are returned.
* modularize authentication using a mixin class * add docstrings and update example notebooks * add tests --------- Co-authored-by: Jessica Scheick <[email protected]> Co-authored-by: Jessica Scheick <[email protected]>
* delete is2cat.py and references * remove intake and related modules Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Jessica Scheick <[email protected]>
* add deprecationerror and raise for use of catalog --------- Co-authored-by: Jessica Scheick <[email protected]>
--------- Co-authored-by: Rachel Wegener <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
👈 Launch a binder notebook on this branch for commit eec037e I will automatically update this comment whenever this PR is modified |
The PR build failed due to login credentials. It seems from the build report that the
and line 4167 and on:
Anyone have ideas about this? |
0 indicates it successfully ran, and the authentication does eventually go through, just not on the first try (so earthdata reports a failure then a success). I wonder if we need to be explicit in creating our session to use .netcdf so it logs in the first time and the "bad" output isn't what's saved as |
The last successful build of main I can find is 0.6.4, so prior to introduction of The options as I see them are: 1) merge/release 0.8.0 anyway and add fixing this to the to-do list for 1.0.0; 2) figure out what the auth issue is and delay releasing 0.8.0 until we've fixed that. @rwegener2 Thoughts? |
Ah, that's helpful background @JessicaS11. It is odd to me that this merge to main is failing even though development merges work fine. Since it's already been done once maybe we just release anyway. The risk, as I see it, is that it doesn't work and we're shipping a broken package, but if it was ok in the last release then odds are good it is fine this time, too (living life on the edge, here). We know of at least one user that is waiting on a release of some of the content, so I suppose my vote is to ship it? This can perhaps serve as another push to invest some time in tests. And on a technical note:
Good point. I am confused about the "failing then succeeding" cycle, so we should circle back to that. Update: I started a ticket (#448). Feel free to add/edit if I didn't hit the core of the issue. |
This is because the
Agreed. No idea if it's relevant for solving the problem, either. |
A minor release of icepyx! 🎉❄️