GSF CubicInterpolation oscillation fix. (#46)

* changed cubic spline to Pchip, fix #45 * add test for #45
icecube · Nov 21, 2024 · 23e4d3e · 23e4d3e
1 parent ecb840d
commit 23e4d3e
Show file tree

Hide file tree

Showing 3 changed files with 205 additions and 193 deletions.
diff --git a/src/simweights/_fluxes.py b/src/simweights/_fluxes.py
@@ -23,7 +23,7 @@
 
 from numpy import asarray, bool_, broadcast_arrays, exp, float64, genfromtxt, int32, piecewise, sqrt
 from numpy import sum as nsum
-from scipy.interpolate import CubicSpline  # pylint: disable=import-error
+from scipy.interpolate import PchipInterpolator  # pylint: disable=import-error
 
 from ._pdgcode import PDGCode
 
@@ -345,7 +345,7 @@ def __init__(self: GlobalSplineFitBase) -> None:
         self._funcs = []
         for z_low, z_high in self.groups:
             self._funcs.append(
-                CubicSpline(energy, nsum(elements[z_low - 1 : z_high], axis=0), extrapolate=False, axis=0),
+                PchipInterpolator(energy, nsum(elements[z_low - 1 : z_high], axis=0), extrapolate=False, axis=0),
             )