Enable (in)equality constraints for use with local and global scipy minimizers #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interface; support a few more minimisers; adredefine _minimizer_callback signature to support trust-constr; add quick minimiser tests; minor touchups
|
closes #834 |
|
still need to make sure that constraints are correctly passed through to other minimisation schemes apart from simple local ones |
…as much as possible
thehrh
changed the title
scipy.optimize.minimize interface
|
closes #842 |
|
Note that various of the new minimiser unit tests "fail" (error is caught and reported but not re-raised) due to scipy bugs/quirks. I think pisa shouldn't prevent the user from trying out the various minimisation interfaces and options scipy provides in principle, even if some of these are buggy (either always or only when given certain configurations). This should also lower maintenance cost and raise awareness of existing enhancement potential. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_minimizer_callbacksignature to support "trust-constr" minimiser