-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dataset index and add PSTracks v4.2, NT v5.1 #180
Conversation
1abaf69
to
2be2209
Compare
Requesting a review! Please note that the commit history is a bit chaotic due to some kind of merge/rebase mistake on my part. Will make sure to squash everything on merge. |
Thanks for all this @mlincett! One broad comment though: this is a lot of changes which are not really all directly coupled together. As a general rule, I think one PR per issue is optimal, and here at least I'd say this could have been more easy to review if it was several independent PRs. Reviewing smaller pieces is easier than doing it all at once. |
You are right, and I was indeed a bit worried about this. Somehow it came natural to implement one feature/fix to help with testing another. But now that everything is there I am fine with splitting this into three/four separate PRs. |
@@ -437,7 +437,9 @@ def make_cluster_submission_script(self): | |||
"eval $(/cvmfs/icecube.opensciencegrid.org/py3-v4.1.0/setup.sh) \n" | |||
"export PYTHONPATH=" + DESYSubmitter.root_dir + "/ \n" | |||
"export FLARESTACK_SCRATCH_DIR=" + flarestack_scratch_dir + " \n" | |||
"python " + fs_dir + "core/multiprocess_wrapper.py -f $1 -n $2 \n" | |||
f"{sys.executable} " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this is over 3 lines? The rest is one python code line per outputted line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what black
does.
I think it's too much work to split this now, but just something to bear in mind for next time |
Uhm, I still think it will save us a lot of headaches and make the review quicker. Will split this in five different PR! |
This PR:
ResultsHandler
handling of errors, closes LetResultsHandler
constructor fail gracefully while storing avalid
flag #207;