Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added module declaration ("declare module") #320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreash
Copy link

@andreash andreash commented Apr 6, 2023

The d.ts file is missing a module declaration for typescript to work. Without the declaration, typescript does not accept, for example Validator as a constructable expression.

The d.ts file is missing a module declaration for typescript to work
@icebob
Copy link
Owner

icebob commented Apr 9, 2023

Could you show an example when it causes issue?

@erfanium
Copy link
Collaborator

and I guess this will break the module in other runtime like deno. because they don't have such a module concept like what node does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants