extension in urls, filename validation (#33)

server/http/storage_nip96.go

@@ -123,6 +123,10 @@ func (s *storageHandler) Upload() gin.HandlerFunc {
 			gCtx.JSON(http.StatusBadRequest, uploadErr("file required"))
 			return
 		}
+		if upload.File.Filename == "" || strings.Contains(upload.File.Filename, "..") {
+			gCtx.JSON(http.StatusBadRequest, uploadErr("invalid filename, must be provided"))
+			return
+		}
 		if upload.MediaType != "" && upload.MediaType != mediaTypeAvatar && upload.MediaType != mediaTypeBanner {
 			gCtx.JSON(http.StatusBadRequest, uploadErr(fmt.Sprintf("unsupported media type %v", upload.MediaType)))
 			return
@@ -253,6 +257,9 @@ func (s *storageHandler) serveFileFromStorage() gin.HandlerFunc {
 			masterPubkey = spl[0]
 			file = spl[1]
 		}
+		if strings.Contains(file, ".") {
+			file = strings.TrimSuffix(file, filepath.Ext(file))
+		}
 		filePath, err := s.storageClient.FilePath(masterPubkey, file)
 		if err != nil {
 			if errors.Is(err, storage.ErrNotFound) {

storage/upload.go

@@ -192,7 +192,7 @@ func (c *client) buildUrl(bagID, relativePath, masterPubkey, fileHash string, bo
 		if err != nil {
 			return "", errors.Wrapf(err, "invalid relay-url configured %v", globalConfig.RelayURL)
 		}
-		return fmt.Sprintf("https://%v:%v/files/%v:%v", relayUrl.Hostname(), relayUrl.Port(), masterPubkey, fileHash), nil
+		return fmt.Sprintf("https://%v:%v/files/%v:%v%v", relayUrl.Hostname(), relayUrl.Port(), masterPubkey, fileHash, filepath.Ext(relativePath)), nil
 	}
 	url := fmt.Sprintf("http://%v.bag/%v?bootstrap=%v", bagID, relativePath, bootstrap)