Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigate to the profile from the story #408

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

ice-alcides
Copy link
Contributor

@ice-alcides ice-alcides commented Dec 10, 2024

Description

  • update rule in build.yaml to optimize the code generation for go_router_builder
  • update routing and navigation logic for the story viewer and the bottom navbar (the bottom navbar is hidden when we open StoryViewerRoute)
  • pause/resume the story's progress during the routing to ProfileRoute

Additional Notes

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation
  • Chore

Screenshots (if applicable)

story-to-profile.mov

@ice-alcides ice-alcides requested review from a team as code owners December 10, 2024 10:44
@ice-alcides ice-alcides self-assigned this Dec 10, 2024
@ice-alcides ice-alcides force-pushed the bugfix/story-to-profile branch from 8ac4a41 to a8e63e5 Compare December 12, 2024 08:13
@ice-alcides ice-alcides merged commit d292680 into master Dec 12, 2024
1 check passed
@ice-alcides ice-alcides deleted the bugfix/story-to-profile branch December 12, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants