Task completion prizes related on santa types values without any completion order #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice-ares
reviewed
Aug 5, 2024
ice-ares
reviewed
Aug 8, 2024
tokenomics/balance.go
Outdated
| CompletedTasks uint64 `json:"completedTasks,omitempty" example:"3"` | ||
| } | ||
| if err = json.UnmarshalContext(ctx, message.Value, &val); err != nil || val.UserID == "" || val.CompletedTasks != requiredCompletedTasks { | ||
| if err = json.UnmarshalContext(ctx, message.Value, &val); err != nil || val.UserID == "" { | ||
| return errors.Wrapf(err, "process: cannot unmarshall %v into %#v", string(message.Value), &val) | ||
| } | ||
| duplGuardKey := fmt.Sprintf("completed_tasks_ice_prize_dupl_guards:%v", val.UserID) |
There was a problem hiding this comment.
add val.Type as well in the template
ice-ares
reviewed
Aug 8, 2024
ice-myles
force-pushed
the
feature/task-completion-prizes
branch
from
6148ae6 to
0338a24
Compare
ice-myles
force-pushed
the
feature/task-completion-prizes
branch
from
77f391d to
a63dd9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task completion prizes related on santa types values without any completion order