Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 20, ESLint 9 #536

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Node 20, ESLint 9 #536

merged 2 commits into from
Jan 3, 2025

Conversation

mshriver
Copy link
Contributor

@mshriver mshriver commented Dec 12, 2024

Updating to eslint9, including prettier (no config yet), and moving to new config format for eslint.

  • cypress/react18 warning.
  • Investigate the file upload test failure. Upload works in the running app right now, it's just the test.
  • Frontend build failure

@mshriver mshriver force-pushed the eslint-update branch 3 times, most recently from 72c3837 to 37437fc Compare December 17, 2024 14:15
@mshriver mshriver force-pushed the eslint-update branch 3 times, most recently from 8f49827 to 9ae0c2e Compare December 17, 2024 16:17
@mshriver mshriver changed the title Eslint update Node 20, ESLint 9, react-router v7 Dec 18, 2024
@mshriver mshriver force-pushed the eslint-update branch 3 times, most recently from 5a231d8 to 06a701c Compare December 18, 2024 17:49
@mshriver mshriver changed the title Node 20, ESLint 9, react-router v7 Node 20, ESLint 9 Dec 19, 2024
@mshriver mshriver added frontend dependencies Pull requests that update a dependency file labels Dec 19, 2024
@mshriver mshriver force-pushed the eslint-update branch 3 times, most recently from ede05c5 to 00fa2cf Compare December 19, 2024 14:10
@mshriver mshriver marked this pull request as ready for review December 19, 2024 14:10
@mshriver mshriver force-pushed the eslint-update branch 3 times, most recently from a551d6a to f5516bf Compare January 3, 2025 17:09
rework eslint config

steal some from content-sources-frontend

Add globals dep for eslint config

Manual fixes for eslint9

Removed some JSX chunks with `false && <element>` syntax

ignore cypress screenshots dir

Update fileUpload and test

In fileUpload, use a function prototype instead of null and just always
call it.

In the testcase, use cy.intercept since afterUpload won't get called
when the POST fails because the backend isn't running
@mshriver mshriver merged commit 7214327 into ibutsu:main Jan 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants