Issue1781 port placement #1782
Merged
Issue1781 port placement #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwetter
approved these changes
Sep 5, 2023
|
@FWuellhorst : Can you please do a review of this feature so we have a non-LBNL person reviewing it. Thanks. |
FWuellhorst
reviewed
Sep 7, 2023
FWuellhorst
approved these changes
Sep 7, 2023
|
@mwetter This is ready to merge. |
AntoineGautier
added a commit
that referenced
this pull request
Sep 20, 2023
This is done manually as git apply with diff from d2edb0c fails. error: IBPSA/Fluid/Interfaces/PartialTwoPort.mo: patch does not apply
mwetter
added a commit
that referenced
this pull request
Sep 22, 2023
Revert most of the changes from #1782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1781.
I also proposed in commit 60c19a7 to modify port placement in
Fluid/Storage/BaseClasses/PartialStratified.mo. Although it may annoy a few users (whose model diagrams will be modified) it will benefit many future users (with a more intuitive icon layout). But I can also revert that change if the disturbance is too big.