Fix BoundVThreadTest - Bad Thread Object #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babsingh
force-pushed
the
fix_BoundVThreadTest
branch
from
d7baaec to
41c0198
Compare
|
@tajila Requesting your review. See eclipse-openj9/openj9#17868 (comment) for more details about the test failure. This PR should be merged after eclipse-openj9/openj9#17912; otherwise, this test will consistently fail. |
After GetAllStackTraces, derive the thread object from the stack_info array, which is filled by GetAllStackTraces. Currently, the thread object is retrieved from the threads_ptr array, which is filled by GetAllThreads before the call to GetAllStackTraces. Live platform threads might have been created or destroyed between the call to GetAllThreads and GetAllStackTraces. This makes the threads_ptr array stale after GetAllStackTraces. A bad thread object is accessed from the stale threads_ptr which causes a segfault. Related: eclipse-openj9/openj9#17868 Signed-off-by: Babneet Singh <[email protected]>
babsingh
force-pushed
the
fix_BoundVThreadTest
branch
from
41c0198 to
5cc2491
Compare
This was referenced Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After GetAllStackTraces, derive the thread object from the
stack_info array, which is filled by GetAllStackTraces.
Currently, the thread object is retrieved from the threads_ptr
array, which is filled by GetAllThreads before the call to
GetAllStackTraces. Live platform threads might have been created
or destroyed between the call to GetAllThreads and GetAllStackTraces.
This makes the threads_ptr array stale after GetAllStackTraces. A bad
thread object is accessed from the stale threads_ptr which causes a
segfault.
Related: eclipse-openj9/openj9#17868
Signed-off-by: Babneet Singh [email protected]