change to only upload files in allowed routes

[raphaelgoms]

Solution to #18 :

• We now only allow file upload in explicitly allowed routes.
• To do this, we added a parameter options to ExpressWraper._request function.

To allow file upload in a route, options should look like { acceptFiles: true, ... }

[marcelomachado]

@raphaelgoms this option should be documented at least as a comment.

[raphaelgoms]

I documented in readme. The text is ok?

[eltonfss]

Looks good to me, although an in code comment would suffice too

[eltonfss]

Looking again at this, it seems to me, the need of this parameter is not making much sense as it introduces a seemingly unnecessary backward compatibility issue.

[marcelomachado]

@raphaelgoms you will probably have to make changes in KES and HKLib to reflect this modification. KES send files to some routes to be imported in HKBase.

[raphaelgoms]

@raphaelgoms you will probably have to make changes in KES and HKLib to reflect this modification. KES send files to some routes to be imported in HKBase.

The only routes I found using the req.files array were:

PUT /repository/:repoName/entity
POST /repository/:repoName/rdf/bulk/:context?

@marcelomachado @eltonfss do you know any other routes that this change could affect?

[srfiorini]

Changes look ok and have been discussed.

[eltonfss]

@raphaelgoms you will probably have to make changes in KES and HKLib to reflect this modification. KES send files to some routes to be imported in HKBase.

The only routes I found using the req.files array were:

PUT /repository/:repoName/entity
POST /repository/:repoName/rdf/bulk/:context?

@marcelomachado @eltonfss do you know any other routes that this change could affect?

PUT /repository/:repoName/entity is a very critical endpoint for the ingestion of HK entities.
POST /repository/:repoName/rdf/bulk/:context?is probably less used but is also important.
Thus I recommend that @raphaelgoms tests the import of HK and Bulk RDF Ingestion after merging the changes to validate that they were not affected.
It seems likely that the options.acceptFiles parameter will have to be added to KES calls of those endpoints.

[eltonfss]

Will abort this pull request as it is not essencial at the moment and could require a major release to be generated. Will keep the branch alive for future releases.

[marcelomachado]

@raphaelgoms you will probably have to make changes in KES and HKLib to reflect this modification. KES send files to some routes to be imported in HKBase.

The only routes I found using the req.files array were:

PUT /repository/:repoName/entity
POST /repository/:repoName/rdf/bulk/:context?

@marcelomachado @eltonfss do you know any other routes that this change could affect?

@raphaelgoms you will probably have to make changes in KES and HKLib to reflect this modification. KES send files to some routes to be imported in HKBase.

The only routes I found using the req.files array were:

PUT /repository/:repoName/entity
POST /repository/:repoName/rdf/bulk/:context?

@marcelomachado @eltonfss do you know any other routes that this change could affect?

PUT /repository/:repoName/entity is a very critical endpoint for the ingestion of HK entities. POST /repository/:repoName/rdf/bulk/:context? is probably less used but is also important. Thus I recommend that @raphaelgoms tests the import of HK and Bulk RDF Ingestion after merging the changes to validate that they were not affected. It seems likely that the options.acceptFiles parameter will have to be added to KES calls of those endpoints.

POST /repository/:repoName/rdf/bulk/:context? this route is very important when it comes to ingesting large databases.

By now I can't remember any other routes.