Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobility data validator 4.1.0 #996

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Mobility data validator 4.1.0 #996

merged 5 commits into from
Nov 9, 2023

Conversation

miles-grant-ibigroup
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup commented Oct 20, 2023 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)

Description

Partner PR to ibi-group/datatools-server#560 ibi-group/datatools-server#571

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Oct 20, 2023
@miles-grant-ibigroup miles-grant-ibigroup mentioned this pull request Oct 20, 2023
Merged
@miles-grant-ibigroup miles-grant-ibigroup added the BLOCKED Blocked (waiting on another PR to be merged) label Oct 23, 2023
@philip-cline
Copy link
Contributor

Is this ready for review now that ibi-group/datatools-server#571 is unblocked? Or is more work required?

@miles-grant-ibigroup miles-grant-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Nov 7, 2023
@miles-grant-ibigroup miles-grant-ibigroup marked this pull request as ready for review November 7, 2023 13:19
AdrianaCeric
AdrianaCeric reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@AdrianaCeric AdrianaCeric left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey could you give me context for some of these changes nm ty Phil

AdrianaCeric
AdrianaCeric approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes!

philip-cline
philip-cline approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@miles-grant-ibigroup miles-grant-ibigroup merged commit 6e6185b into dev Nov 9, 2023
5 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the mobility-data-validator-4.1.0 branch November 9, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philip-cline philip-cline philip-cline approved these changes

@AdrianaCeric AdrianaCeric AdrianaCeric approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @philip-cline @AdrianaCeric