allow URL type for router and build config #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philip-cline
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
I tested this while I was testing the backend PR so thought I'd give a review. Looks good, left a couple of nit picky comments and questions. The naming convention of custom vs. customUrl can sometimes be confusing but I'm not sure it can be easily elucidated.
daniel-heppner-ibigroup
approved these changes
Dec 19, 2023
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows us to use ibi-group/datatools-server#577
Adds a third radio button to both configs. I tried to keep things abstract, but I think things are a bit messy. Looking for feedback on cleaning this up.
The issue is the way we determine if URL or text mode is active is by looking for the presence of URL data. Custom text should be preserved when URL is active.