Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix everything #565

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix everything #565

merged 1 commit into from
Sep 29, 2023

Conversation

philip-cline
Copy link
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Shared stops was broken for a while bc of fetching a feedId when it had not been written yet. This PR fixes that issue and also fixes an error with the FeedSourceTable by adjusting the mongo query feedSourceSummaries relies on

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Sep 29, 2023
miles-grant-ibigroup
miles-grant-ibigroup approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything passed

@miles-grant-ibigroup
Copy link
Contributor

Merging with verbal approval from @daniel-heppner-ibigroup

@miles-grant-ibigroup miles-grant-ibigroup merged commit 390423e into dev Sep 29, 2023
@miles-grant-ibigroup miles-grant-ibigroup deleted the fix-shared-stops branch September 29, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

@daniel-heppner-ibigroup daniel-heppner-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philip-cline @miles-grant-ibigroup @daniel-heppner-ibigroup