Add validation for directions.txt #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
br648
requested changes
Sep 27, 2023
src/main/java/com/conveyal/datatools/manager/gtfsplus/GtfsPlusValidation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/gtfsplus/GtfsPlusValidation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/gtfsplus/GtfsPlusValidation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/gtfsplus/GtfsPlusValidation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/gtfsplus/GtfsPlusValidation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/gtfsplus/GtfsPlusValidation.java
Outdated
Show resolved
Hide resolved
br648
approved these changes
Sep 28, 2023
|
|
||
| Set<String> gtfsRoutes = new HashSet<>(); | ||
| if (tableIsDirections) { | ||
| // Copy the gtfs routes into a map we can "check them off" in (remove them). Stream is required in order to copy keys. |
There was a problem hiding this comment.
Stream is required....
Is that sentence still needed?
There was a problem hiding this comment.
Updated in 5529162
| // Expect issues to be zero. | ||
| assertThat("Issues count for clean BART feed is zero", validation.issues.size(), equalTo(0)); | ||
| // Expect issues to be only one with directions.txt file | ||
| assertThat("Issues count for clean BART feed is zero", validation.issues.size(), equalTo(1)); |
There was a problem hiding this comment.
Update the description of the test (e.g. "Clean BART feed and incomplete directions.txt results in one issue.")
There was a problem hiding this comment.
Updated in e9cd115
|
Updated this to match the latest language in the MTC branch. Should be the same as that previously closed PR. Note if you're testing this you should merge dev into this branch to get the latest updates |
binh-dam-ibigroup
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
It has recently been pointed out that a lack of route records in the GTFS+ directions.txt can cause direction data to become unavailable in downstream systems. This PR provides validation of the GTFS+ directions.txt table to ensure that every route has a corresponding entry.