Remove parent publishedVersionId if when deleting FeedVersion #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eting FeedVersion.
philip-cline
approved these changes
Apr 20, 2023
src/test/java/com/conveyal/datatools/manager/models/FeedVersionTest.java
Outdated
Show resolved
Hide resolved
br648
requested changes
Apr 25, 2023
| * {@link FeedSource::publishedVersionId} should be unset if it references a feed version being deleted. | ||
| */ | ||
| @Test | ||
| void shouldDeletePublishedVersionIdWhenDeletingVersion() { |
There was a problem hiding this comment.
I'm not sure if this is an OS thing, but the feed versions are not deleted after the test has complete from Mongo:
Could not drop feed for namespace published_namespace - ERROR: schema "published_namespace" does not exist.
There was a problem hiding this comment.
Good catch. I suppose the error occurs because the respective namespaces are never created in PostgreSQL, so it fails to delete them.
There was a problem hiding this comment.
Added comments and cleanup code in 70a01b7.
…s with fake namespaces.
br648
approved these changes
Apr 25, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Fix #527. See issue for required settings to reproduce that bug.
This PR ensures that feed source
publishedVersionIdthat refer to a feed version being deleted are unset (set to null).Note: This PR does not address the cause for partially deleted namespaces described in the issue.