-
Notifications
You must be signed in to change notification settings - Fork 53
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
27 changed files
with
1,142 additions
and
382 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
126 changes: 126 additions & 0 deletions
126
src/main/java/com/conveyal/datatools/manager/jobs/validation/SharedStopsValidator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| package com.conveyal.datatools.manager.jobs.validation; | ||
|
|
||
| import com.conveyal.datatools.manager.models.Project; | ||
| import com.conveyal.gtfs.error.NewGTFSError; | ||
| import com.conveyal.gtfs.error.NewGTFSErrorType; | ||
| import com.conveyal.gtfs.error.SQLErrorStorage; | ||
| import com.conveyal.gtfs.loader.Feed; | ||
| import com.conveyal.gtfs.model.Stop; | ||
| import com.conveyal.gtfs.validator.FeedValidator; | ||
| import com.csvreader.CsvReader; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.ArrayList; | ||
| import java.util.HashMap; | ||
| import java.util.HashSet; | ||
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
|
|
||
| public class SharedStopsValidator extends FeedValidator { | ||
| private static final Logger LOG = LoggerFactory.getLogger(SharedStopsValidator.class); | ||
|
|
||
| Feed feed; | ||
| String feedId; | ||
| Project project; | ||
|
|
||
| public SharedStopsValidator(Project project, String feedId) { | ||
| super(null, null); | ||
| this.project = project; | ||
| this.feedId = feedId; | ||
| } | ||
|
|
||
| // This method can only be run on a SharedStopsValidator that has been set up with a project only | ||
| public SharedStopsValidator buildSharedStopsValidator(Feed feed, SQLErrorStorage errorStorage) { | ||
| if (this.project == null) { | ||
| throw new RuntimeException("Shared stops validator can not be called because no project has been set!"); | ||
| } | ||
| if (this.feedId == null) { | ||
| throw new RuntimeException("Shared stops validator can not be called because no feed ID has been set!"); | ||
| } | ||
| return new SharedStopsValidator(feed, errorStorage, this.project, this.feedId); | ||
| } | ||
| public SharedStopsValidator(Feed feed, SQLErrorStorage errorStorage, Project project, String feedId) { | ||
| super(feed, errorStorage); | ||
| this.feed = feed; | ||
| this.project = project; | ||
| this.feedId = feedId; | ||
| } | ||
|
|
||
| @Override | ||
| public void validate() { | ||
| String config = project.sharedStopsConfig; | ||
| if (config == null) { | ||
| return; | ||
| } | ||
|
|
||
| CsvReader configReader = CsvReader.parse(config); | ||
|
|
||
| // TODO: pull indicies from the CSV header | ||
| final int STOP_GROUP_ID_INDEX = 0; | ||
| final int STOP_ID_INDEX = 2; | ||
| final int IS_PRIMARY_INDEX = 3; | ||
| final int FEED_ID_INDEX = 1; | ||
|
|
||
| // Build list of stop Ids. | ||
| List<String> stopIds = new ArrayList<>(); | ||
| List<Stop> stops = new ArrayList<>(); | ||
|
|
||
| for (Stop stop : feed.stops) { | ||
| stops.add(stop); | ||
| stopIds.add(stop.stop_id); | ||
| } | ||
|
|
||
| // Initialize hashmaps to hold duplication info | ||
| HashMap<String, Set<String>> stopGroupStops = new HashMap<>(); | ||
| HashSet<String> stopGroupsWithPrimaryStops = new HashSet<>(); | ||
|
|
||
| try { | ||
| while (configReader.readRecord()) { | ||
| String stopGroupId = configReader.get(STOP_GROUP_ID_INDEX); | ||
| String stopId = configReader.get(STOP_ID_INDEX); | ||
| String sharedStopFeedId = configReader.get(FEED_ID_INDEX); | ||
|
|
||
| if (stopId.equals("stop_id")) { | ||
| // Swallow header row | ||
| continue; | ||
| } | ||
|
|
||
| stopGroupStops.putIfAbsent(stopGroupId, new HashSet<>()); | ||
| Set<String> seenStopIds = stopGroupStops.get(stopGroupId); | ||
|
|
||
| // Check for SS_01 (stop id appearing in multiple stop groups) | ||
| if (seenStopIds.contains(stopId)) { | ||
| registerError(stops | ||
| .stream() | ||
| .filter(stop -> stop.stop_id.equals(stopId)) | ||
| .findFirst() | ||
| .orElse(stops.get(0)), NewGTFSErrorType.MULTIPLE_SHARED_STOPS_GROUPS | ||
| ); | ||
| } else { | ||
| seenStopIds.add(stopId); | ||
| } | ||
|
|
||
| // Check for SS_02 (multiple primary stops per stop group) | ||
| if (stopGroupsWithPrimaryStops.contains(stopGroupId)) { | ||
| registerError(NewGTFSError.forFeed(NewGTFSErrorType.SHARED_STOP_GROUP_MUTLIPLE_PRIMARY_STOPS, stopGroupId)); | ||
| } else if (configReader.get(IS_PRIMARY_INDEX).equals("true")) { | ||
| stopGroupsWithPrimaryStops.add(stopGroupId); | ||
| } | ||
|
|
||
| // Check for SS_03 (stop_id referenced doesn't exist) | ||
| // Make sure this error is only returned if we are inside the feed that is being checked | ||
| if (feedId.equals(sharedStopFeedId) && !stopIds.contains(stopId)) { | ||
| registerError(NewGTFSError.forFeed(NewGTFSErrorType.SHARED_STOP_GROUP_ENTITY_DOES_NOT_EXIST, stopId)); | ||
| } | ||
| } | ||
| } catch (IOException e) { LOG.error(e.toString()); } | ||
| finally { | ||
| configReader.close(); | ||
| } | ||
|
|
||
|
|
||
| } | ||
| } |
Oops, something went wrong.