IBX-8139: Dropped class_alias BC layer statements from all classes (#49)

For more details see https://issues.ibexa.co/browse/IBX-8139 and #49

Key changes:

* Dropped class_alias BC layer from production code

* Dropped class_alias BC layer from test code

* [Composer] Dropped legacy namespaces from autoload section

* [Tests] Fixed usage of legacy namespace in Behat scenario

composer.json

@@ -42,15 +42,13 @@
         "psr-4": {
             "Ibexa\\HttpCache\\": "src/lib/",
             "Ibexa\\Bundle\\HttpCache\\": "src/bundle/",
-            "Ibexa\\Contracts\\HttpCache\\": "src/contracts/",
-            "EzSystems\\PlatformHttpCacheBundle\\": "src/bundle/"
+            "Ibexa\\Contracts\\HttpCache\\": "src/contracts/"
         }
     },
     "autoload-dev": {
         "psr-4": {
             "Ibexa\\Tests\\HttpCache\\": "tests/lib/",
-            "Ibexa\\Tests\\Bundle\\HttpCache\\": "tests/bundle/",
-            "EzSystems\\PlatformHttpCacheBundle\\Tests\\": "tests"
+            "Ibexa\\Tests\\Bundle\\HttpCache\\": "tests/bundle/"
         }
     },
     "scripts": {

features/setup/symfonyCache.feature

@@ -21,7 +21,7 @@ index 9982c21..03ac40a 100644
  <?php
  
  use App\Kernel;
-+use EzSystems\PlatformHttpCacheBundle\AppCache;
++use Ibexa\Bundle\HttpCache\AppCache;
 +use Symfony\Component\HttpFoundation\Request;
  
  require_once dirname(__DIR__).'/vendor/autoload_runtime.php';

src/bundle/AppCache.php

@@ -116,5 +116,3 @@ protected function cleanupHeadersForProd(Response $response)
         }
     }
 }
-
-class_alias(AppCache::class, 'EzSystems\PlatformHttpCacheBundle\AppCache');

src/bundle/Controller/InvalidateTokenController.php

@@ -80,5 +80,3 @@ public function tokenAction(Request $request)
         return $response;
     }
 }
-
-class_alias(InvalidateTokenController::class, 'EzSystems\PlatformHttpCacheBundle\Controller\InvalidateTokenController');

src/bundle/DependencyInjection/Compiler/DriverPass.php

@@ -70,5 +70,3 @@ public static function getTaggedService(ContainerBuilder $container, $tag)
         return $configuredTagHandlerServiceId;
     }
 }
-
-class_alias(DriverPass::class, 'EzSystems\PlatformHttpCacheBundle\DependencyInjection\Compiler\DriverPass');

src/bundle/DependencyInjection/Compiler/KernelPass.php

@@ -93,5 +93,3 @@ protected function isCachePurger($id)
         return strpos($id, 'ezpublish.http_cache.purger.') === 0;
     }
 }
-
-class_alias(KernelPass::class, 'EzSystems\PlatformHttpCacheBundle\DependencyInjection\Compiler\KernelPass');

src/bundle/DependencyInjection/Compiler/ResponseTaggersPass.php

@@ -34,5 +34,3 @@ public function process(ContainerBuilder $container)
         $dispatcher->replaceArgument(0, $taggers);
     }
 }
-
-class_alias(ResponseTaggersPass::class, 'EzSystems\PlatformHttpCacheBundle\DependencyInjection\Compiler\ResponseTaggersPass');

src/bundle/DependencyInjection/Compiler/VarnishCachePass.php

@@ -40,5 +40,3 @@ private function processVarnishProxyClientSettings(ContainerBuilder $container)
         );
     }
 }
-
-class_alias(VarnishCachePass::class, 'EzSystems\PlatformHttpCacheBundle\DependencyInjection\Compiler\VarnishCachePass');

src/bundle/DependencyInjection/ConfigResolver/HttpCacheConfigParser.php

@@ -97,5 +97,3 @@ private function getExtraConfigParsers()
         return $this->httpCacheExtension->getExtraConfigParsers();
     }
 }
-
-class_alias(HttpCacheConfigParser::class, 'EzSystems\PlatformHttpCacheBundle\DependencyInjection\ConfigResolver\HttpCacheConfigParser');

src/bundle/DependencyInjection/Configuration.php

@@ -25,5 +25,3 @@ public function getConfigTreeBuilder()
         return new TreeBuilder('ibexa_http_cache');
     }
 }
-
-class_alias(Configuration::class, 'EzSystems\PlatformHttpCacheBundle\DependencyInjection\Configuration');

src/bundle/DependencyInjection/IbexaHttpCacheExtension.php

@@ -77,5 +77,3 @@ public function getExtraConfigParsers()
         return $this->extraConfigParsers;
     }
 }
-
-class_alias(IbexaHttpCacheExtension::class, 'EzSystems\PlatformHttpCacheBundle\DependencyInjection\EzPlatformHttpCacheExtension');

src/bundle/IbexaHttpCacheBundle.php

@@ -67,5 +67,3 @@ public function registerConfigParser(ContainerBuilder $container)
         );
     }
 }
-
-class_alias(IbexaHttpCacheBundle::class, 'EzSystems\PlatformHttpCacheBundle\EzSystemsPlatformHttpCacheBundle');

src/contracts/Handler/ContentTagInterface.php

@@ -83,5 +83,3 @@ public function addRelationLocationTags(array $locationIds);
      */
     public function addContentTypeTags(array $contentTypeIds);
 }
-
-class_alias(ContentTagInterface::class, 'EzSystems\PlatformHttpCacheBundle\Handler\ContentTagInterface');

src/contracts/PurgeClient/PurgeClientInterface.php

@@ -28,5 +28,3 @@ public function purge(array $tags): void;
      */
     public function purgeAll(): void;
 }
-
-class_alias(PurgeClientInterface::class, 'EzSystems\PlatformHttpCacheBundle\PurgeClient\PurgeClientInterface');

src/contracts/ResponseTagger/ResponseTagger.php

@@ -19,5 +19,3 @@ interface ResponseTagger
      */
     public function tag($value);
 }
-
-class_alias(ResponseTagger::class, 'EzSystems\PlatformHttpCacheBundle\ResponseTagger\ResponseTagger');

src/lib/ContextProvider/RoleIdentify.php

@@ -78,5 +78,3 @@ static function (Repository $repository) use ($user) {
         $context->addParameter('roleLimitationList', $limitationValues);
     }
 }
-
-class_alias(RoleIdentify::class, 'EzSystems\PlatformHttpCacheBundle\ContextProvider\RoleIdentify');

src/lib/EventListener/ConditionallyRemoveVaryHeaderListener.php

@@ -79,5 +79,3 @@ public static function getSubscribedEvents()
         ];
     }
 }
-
-class_alias(ConditionallyRemoveVaryHeaderListener::class, 'EzSystems\PlatformHttpCacheBundle\EventListener\ConditionallyRemoveVaryHeaderListener');

src/lib/EventSubscriber/CachePurge/AbstractSubscriber.php

@@ -93,5 +93,3 @@ public function getContentUrlTags(int $urlId): array
         return $tags;
     }
 }
-
-class_alias(AbstractSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\CachePurge\AbstractSubscriber');

src/lib/EventSubscriber/CachePurge/ContentEventsSubscriber.php

@@ -194,5 +194,3 @@ private function isContentTypeFullyTranslatable(ContentType $contentType): bool
         });
     }
 }
-
-class_alias(ContentEventsSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\CachePurge\ContentEventsSubscriber');

src/lib/EventSubscriber/CachePurge/ContentTypeEventsSubscriber.php

@@ -89,5 +89,3 @@ public function onUpdateContentTypeGroup(UpdateContentTypeGroupEvent $event): vo
         ]);
     }
 }
-
-class_alias(ContentTypeEventsSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\CachePurge\ContentTypeEventsSubscriber');

src/lib/EventSubscriber/CachePurge/LocationEventsSubscriber.php

@@ -167,5 +167,3 @@ public function onUpdateLocation(UpdateLocationEvent $event): void
         $this->purgeClient->purge($tags);
     }
 }
-
-class_alias(LocationEventsSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\CachePurge\LocationEventsSubscriber');

src/lib/EventSubscriber/CachePurge/ObjectStateEventsSubscriber.php

@@ -31,5 +31,3 @@ public function onSetContentState(SetContentStateEvent $event): void
         $this->purgeClient->purge($tags);
     }
 }
-
-class_alias(ObjectStateEventsSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\CachePurge\ObjectStateEventsSubscriber');

src/lib/EventSubscriber/CachePurge/RoleEventsSubscriber.php

@@ -35,5 +35,3 @@ public function clearUserContextHashCache(Event $event)
         ]);
     }
 }
-
-class_alias(RoleEventsSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\CachePurge\RoleEventsSubscriber');

src/lib/EventSubscriber/CachePurge/SectionEventsSubscriber.php

@@ -73,5 +73,3 @@ public function onAssignSectionToSubtree(AssignSectionToSubtreeEvent $event): vo
         $this->purgeClient->purge($tags);
     }
 }
-
-class_alias(SectionEventsSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\CachePurge\SectionEventsSubscriber');

src/lib/EventSubscriber/CachePurge/TranslationEventsSubscriber.php

@@ -31,5 +31,3 @@ public function onDeleteTranslation(DeleteTranslationEvent $event): void
         $this->purgeClient->purge($tags);
     }
 }
-
-class_alias(TranslationEventsSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\CachePurge\TranslationEventsSubscriber');

src/lib/EventSubscriber/CachePurge/TrashEventsSubscriber.php

@@ -49,5 +49,3 @@ public function onRecover(RecoverEvent $event): void
         $this->purgeClient->purge($tags);
     }
 }
-
-class_alias(TrashEventsSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\CachePurge\TrashEventsSubscriber');

src/lib/EventSubscriber/CachePurge/UrlEventsSubscriber.php

@@ -30,5 +30,3 @@ public function onUrlUpdate(UpdateUrlEvent $event): void
         }
     }
 }
-
-class_alias(UrlEventsSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\CachePurge\UrlEventsSubscriber');

src/lib/EventSubscriber/CachePurge/UserEventsSubscriber.php

@@ -102,5 +102,3 @@ public function onUpdateUser(UpdateUserEvent $event): void
         $this->purgeClient->purge($tags);
     }
 }
-
-class_alias(UserEventsSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\CachePurge\UserEventsSubscriber');

src/lib/EventSubscriber/HiddenLocationExceptionSubscriber.php

@@ -49,5 +49,3 @@ public function tagHiddenLocationExceptionResponse(ExceptionEvent $event)
         $this->contentInfoTagger->tag($location->getContentInfo());
     }
 }
-
-class_alias(HiddenLocationExceptionSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\HiddenLocationExceptionSubscriber');

src/lib/EventSubscriber/HttpCacheResponseSubscriber.php

@@ -55,5 +55,3 @@ public function configureCache(ResponseEvent $event)
         // NB!: FOSHTTPCacheBundle is taking care about writing the tags in own tag handler happening with priority 0
     }
 }
-
-class_alias(HttpCacheResponseSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\HttpCacheResponseSubscriber');

src/lib/EventSubscriber/RequestEventSubscriber.php

@@ -48,5 +48,3 @@ public function onKernelRequestForward(RequestEvent $event): void
         }
     }
 }
-
-class_alias(RequestEventSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\RequestEventSubscriber');

src/lib/EventSubscriber/RestKernelViewSubscriber.php

@@ -109,5 +109,3 @@ protected function getTags($value)
         return $tags;
     }
 }
-
-class_alias(RestKernelViewSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\RestKernelViewSubscriber');

src/lib/EventSubscriber/UserContextSiteAccessMatchSubscriber.php

@@ -50,5 +50,3 @@ public function checkIfRequestForUserContextHash(RequestEvent $event)
         $this->innerSubscriber->onKernelRequest($event);
     }
 }
-
-class_alias(UserContextSiteAccessMatchSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\UserContextSiteAccessMatchSubscriber');

src/lib/EventSubscriber/UserContextSubscriber.php

@@ -68,5 +68,3 @@ public function tagUserContext(ResponseEvent $event)
         $response->headers->set($this->tagHeader, $this->prefixService->getRepositoryPrefix() . 'ez-user-context-hash');
     }
 }
-
-class_alias(UserContextSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\UserContextSubscriber');

src/lib/EventSubscriber/XLocationIdResponseSubscriber.php

@@ -90,5 +90,3 @@ public function rewriteCacheHeader(ResponseEvent $event)
         $response->headers->remove(static::LOCATION_ID_HEADER);
     }
 }
-
-class_alias(XLocationIdResponseSubscriber::class, 'EzSystems\PlatformHttpCacheBundle\EventSubscriber\XLocationIdResponseSubscriber');

src/lib/Handler/TagHandler.php

@@ -191,5 +191,3 @@ public function addContentTypeTags(array $contentTypeIds)
         }, $contentTypeIds));
     }
 }
-
-class_alias(TagHandler::class, 'EzSystems\PlatformHttpCacheBundle\Handler\TagHandler');

src/lib/Proxy/UserContextListener.php

@@ -24,5 +24,3 @@ protected function cleanupHashLookupRequest(Request $hashLookupRequest, Request
         $hashLookupRequest->attributes->set('_ez_original_request', $originalRequest);
     }
 }
-
-class_alias(UserContextListener::class, 'EzSystems\PlatformHttpCacheBundle\Proxy\UserContextListener');

src/lib/ProxyClient/HttpDispatcherFactory.php

@@ -62,5 +62,3 @@ public function buildHttpDispatcher(array $servers, string $baseUrl = '')
         return new $this->httpDispatcherClass($allServers, $baseUrl);
     }
 }
-
-class_alias(HttpDispatcherFactory::class, 'EzSystems\PlatformHttpCacheBundle\ProxyClient\HttpDispatcherFactory');

src/lib/ProxyClient/Varnish.php

@@ -57,5 +57,3 @@ protected function queueRequest($method, $url, array $headers, $validateHost = t
         parent::queueRequest($method, $url, $this->fetchAndMergeAuthHeaders($headers), $body);
     }
 }
-
-class_alias(Varnish::class, 'EzSystems\PlatformHttpCacheBundle\ProxyClient\Varnish');

src/lib/PurgeClient/LocalPurgeClient.php

@@ -34,5 +34,3 @@ public function purgeAll(): void
         $this->cacheStore->invalidateTags(['ez-all']);
     }
 }
-
-class_alias(LocalPurgeClient::class, 'EzSystems\PlatformHttpCacheBundle\PurgeClient\LocalPurgeClient');

src/lib/PurgeClient/RepositoryPrefixDecorator.php

@@ -53,5 +53,3 @@ public function purgeAll(): void
         $this->purgeClient->purgeAll();
     }
 }
-
-class_alias(RepositoryPrefixDecorator::class, 'EzSystems\PlatformHttpCacheBundle\PurgeClient\RepositoryPrefixDecorator');

src/lib/PurgeClient/VarnishPurgeClient.php

@@ -34,5 +34,3 @@ public function purgeAll(): void
         $this->cacheManager->invalidateTags(['ez-all']);
     }
 }
-
-class_alias(VarnishPurgeClient::class, 'EzSystems\PlatformHttpCacheBundle\PurgeClient\VarnishPurgeClient');

src/lib/RepositoryTagPrefix.php

@@ -54,5 +54,3 @@ public function getRepositoryPrefix()
         return (string) (empty($repositoryIdentifier) ? '' : $this->repositoryMap[$repositoryIdentifier]);
     }
 }
-
-class_alias(RepositoryTagPrefix::class, 'EzSystems\PlatformHttpCacheBundle\RepositoryTagPrefix');

src/lib/ResponseConfigurator/ConfigurableResponseCacheConfigurator.php

@@ -57,5 +57,3 @@ private function getDefaultTTL(): int
         return (int)$this->configResolver->getParameter('content.default_ttl');
     }
 }
-
-class_alias(ConfigurableResponseCacheConfigurator::class, 'EzSystems\PlatformHttpCacheBundle\ResponseConfigurator\ConfigurableResponseCacheConfigurator');

src/lib/ResponseConfigurator/ResponseCacheConfigurator.php

@@ -32,5 +32,3 @@ public function enableCache(Response $response);
      */
     public function setSharedMaxAge(Response $response);
 }
-
-class_alias(ResponseCacheConfigurator::class, 'EzSystems\PlatformHttpCacheBundle\ResponseConfigurator\ResponseCacheConfigurator');

src/lib/ResponseTagger/Delegator/ContentValueViewTagger.php

@@ -33,5 +33,3 @@ public function tag($view)
         $this->contentInfoTagger->tag($contentInfo);
     }
 }
-
-class_alias(ContentValueViewTagger::class, 'EzSystems\PlatformHttpCacheBundle\ResponseTagger\Delegator\ContentValueViewTagger');

src/lib/ResponseTagger/Delegator/DispatcherTagger.php

@@ -31,5 +31,3 @@ public function tag($value)
         }
     }
 }
-
-class_alias(DispatcherTagger::class, 'EzSystems\PlatformHttpCacheBundle\ResponseTagger\Delegator\DispatcherTagger');

src/lib/ResponseTagger/Delegator/LocationValueViewTagger.php

@@ -32,5 +32,3 @@ public function tag($view)
         $this->locationTagger->tag($location);
     }
 }
-
-class_alias(LocationValueViewTagger::class, 'EzSystems\PlatformHttpCacheBundle\ResponseTagger\Delegator\LocationValueViewTagger');

src/lib/ResponseTagger/Value/AbstractValueTagger.php

@@ -20,5 +20,3 @@ public function __construct(FosResponseTagger $responseTagger)
         $this->responseTagger = $responseTagger;
     }
 }
-
-class_alias(AbstractValueTagger::class, 'EzSystems\PlatformHttpCacheBundle\ResponseTagger\Value\AbstractValueTagger');

src/lib/ResponseTagger/Value/ContentInfoTagger.php

@@ -28,5 +28,3 @@ public function tag($value)
         }
     }
 }
-
-class_alias(ContentInfoTagger::class, 'EzSystems\PlatformHttpCacheBundle\ResponseTagger\Value\ContentInfoTagger');

src/lib/ResponseTagger/Value/LocationTagger.php

@@ -33,5 +33,3 @@ static function ($pathItem) {
         );
     }
 }
-
-class_alias(LocationTagger::class, 'EzSystems\PlatformHttpCacheBundle\ResponseTagger\Value\LocationTagger');

src/lib/Twig/ContentTaggingExtension.php

@@ -121,5 +121,3 @@ public function tagHttpCacheForRelationLocationIds($locationIds)
         $this->contentTagHandler->addRelationLocationTags((array)$locationIds);
     }
 }
-
-class_alias(ContentTaggingExtension::class, 'EzSystems\PlatformHttpCacheBundle\Twig\ContentTaggingExtension');

tests/lib/ContextProvider/RoleIdentifyTest.php

@@ -192,5 +192,3 @@ protected function getUserServiceMock()
             ->getMockForAbstractClass();
     }
 }
-
-class_alias(RoleIdentifyTest::class, 'EzSystems\PlatformHttpCacheBundle\Tests\ContextProvider\RoleIdentifyTest');

tests/lib/PurgeClient/LocalPurgeClientTest.php

@@ -40,5 +40,3 @@ static function ($id) {
         $purgeClient->purge($keys);
     }
 }
-
-class_alias(LocalPurgeClientTest::class, 'EzSystems\PlatformHttpCacheBundle\Tests\PurgeClient\LocalPurgeClientTest');

tests/lib/PurgeClient/RepositoryPrefixDecoratorTest.php

@@ -88,5 +88,3 @@ public function testPurgeAll()
         $this->prefixDecorator->purgeAll();
     }
 }
-
-class_alias(RepositoryPrefixDecoratorTest::class, 'EzSystems\PlatformHttpCacheBundle\Tests\PurgeClient\RepositoryPrefixDecoratorTest');

tests/lib/PurgeClient/VarnishPurgeClientTest.php

@@ -88,5 +88,3 @@ public function testPurgeAll()
         $this->purgeClient->purgeAll();
     }
 }
-
-class_alias(VarnishPurgeClientTest::class, 'EzSystems\PlatformHttpCacheBundle\Tests\PurgeClient\VarnishPurgeClientTest');