IBX-7979: Fixed "field" keyword occurrences in fields' identifiers being wrongly replaced #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
changed the title
alongosz
approved these changes
Mar 25, 2024
That would technically mean adding test coverage to entire GraphQL API layer. 😞 |
ciastektk
approved these changes
Mar 29, 2024
konradoboza
force-pushed
the
ibx-7979-fix-field-keyword-replacing
branch
from
4c6a1a5 to
f8f33a6
Compare
|
tomaszszopinski
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.ibexa.co/browse/IBX-7979
Followup for #59 where
returnwas performed too early. I added also some more strict regular expression targeting only actual usage offieldkeyword within fields' identifiers with case-insensitivity taken into account.