Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8150: Added option to enable attributes types #167

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jun 10, 2024

Question Answer
JIRA issue IBX-8150
Bug/Improvement no
New feature yes
Target version 4.6
BC breaks no
Tests pass yes
Doc needed yes/no

Recipes level configuration:
https://github.com/ibexa/recipes-dev/pull/123/files

Example configuration, in packages/ibexa_richtext.yaml if i.e. you want to have choice field disabled:

ibexa_fieldtype_richtext:
    enabled_attribute_types:
        - number
        - string
        - boolean
        - link

QA

To test this, feel free to remove one of the custom tag from allowed list - configuration should then fail same way as using not existing custom tag type.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@ViniTou ViniTou changed the title ibx-8150-enabled-types-config IBX-8150: Added option to enable attributes types Jun 10, 2024
@ViniTou ViniTou force-pushed the ibx-8150-enabled-types-config branch from a2c69eb to 6ab2bf2 Compare June 11, 2024 10:45
@ViniTou ViniTou requested a review from a team June 12, 2024 07:45
src/bundle/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
@webhdx webhdx requested a review from a team June 12, 2024 07:58
@konradoboza konradoboza requested a review from a team June 12, 2024 08:04
@adamwojs
Copy link
Member

@ViniTou Could you please add example configuration to PR description?

Copy link

sonarcloud bot commented Jun 24, 2024

@konradoboza
Copy link
Contributor

@ViniTou marking as ready for qa, as it seems to be complete.

@ViniTou
Copy link
Contributor Author

ViniTou commented Jul 9, 2024

@konradoboza
I wanted to wait for whole Engage Custom Tag to test it, but I guess this could be done separately.

@barbaragr barbaragr self-assigned this Jul 16, 2024
@alongosz alongosz merged commit 5ebad1e into 4.6 Jul 17, 2024
28 checks passed
@alongosz alongosz deleted the ibx-8150-enabled-types-config branch July 17, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants