Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8858: Update Solr config between 4.5 and 4.6 #2486

Merged
merged 6 commits into from
Sep 17, 2024
Merged

IBX-8858: Update Solr config between 4.5 and 4.6 #2486

merged 6 commits into from
Sep 17, 2024

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Sep 5, 2024 •
edited
Loading

Question Answer
JIRA Ticket IBX-8858
Versions 4.6
Edition All

Update Solr config when upgrading from 4.5 to 4.6 to enable spellchecking.

Preview: https://ez-systems-developer-documentation--2486.com.readthedocs.build/en/2486/update_and_migration/from_4.5/update_from_4.5/#update-solr-configuration

ibexa/solr#52 was merged into v4.6.0-beta4

diff -r v4.5.7/solrconfig.xml v4.6.10/solrconfig.xml
767a768,770
>     <arr name="last-components">
>       <str>spellcheck</str>
>     </arr>
911c914
<       <str name="field">_text_</str>
---
>       <str name="field">meta_content__text_t</str>

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis adriendupuis changed the base branch from master to 4.6 September 5, 2024 12:11
@adriendupuis adriendupuis changed the title IBX-8858: Update Solr config when upgrading from 45 to 4.6 to enable spellcheking IBX-8858: Update Solr config when upgrading from 45 to 4.6 Sep 5, 2024
@adriendupuis adriendupuis changed the title IBX-8858: Update Solr config when upgrading from 45 to 4.6 IBX-8858: Update Solr config between 4.5 and 4.6 Sep 5, 2024
@adriendupuis adriendupuis marked this pull request as ready for review September 5, 2024 12:27
@adriendupuis adriendupuis requested a review from vidarl September 5, 2024 12:30
adamwojs
adamwojs requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments below.

docs/update_and_migration/from_4.5/update_from_4.5.md Outdated Show resolved Hide resolved
@adriendupuis adriendupuis requested a review from vidarl September 16, 2024 10:04
@adriendupuis
Merge branch '4.6' into IBX-8858_update-solr-conf
c1af4d5 
# Conflicts:
#	docs/update_and_migration/from_4.5/update_from_4.5.md
@adriendupuis
update_from_3.3.md: EOL@EOF
10e9296
julitafalcondusza
julitafalcondusza requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@julitafalcondusza julitafalcondusza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.

docs/update_and_migration/from_4.5/update_from_4.5.md Outdated Show resolved Hide resolved
docs/update_and_migration/from_4.5/update_from_4.5.md Outdated Show resolved Hide resolved
@adriendupuis @julitafalcondusza
Apply suggestions from code review
5007f1f 
Co-authored-by: julitafalcondusza <[email protected]>
@adriendupuis adriendupuis merged commit fa9e8cb into 4.6 Sep 17, 2024
5 checks passed
@adriendupuis adriendupuis deleted the IBX-8858_update-solr-conf branch September 17, 2024 09:02
adriendupuis added a commit that referenced this pull request Sep 17, 2024
@adriendupuis
IBX-8858: Update Solr config between 4.5 and 4.6 (#2486)
620fdb9
adriendupuis added a commit that referenced this pull request Sep 17, 2024
@adriendupuis
IBX-8858: Update Solr config between 4.5 and 4.6 (#2486)
058284e
mnocon pushed a commit that referenced this pull request Nov 8, 2024
@adriendupuis @mnocon
IBX-8858: Update Solr config between 4.5 and 4.6 (#2486)
24a4ab3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julitafalcondusza julitafalcondusza julitafalcondusza approved these changes

@vidarl vidarl vidarl approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees
No one assigned
Labels
Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adriendupuis @adamwojs @vidarl @julitafalcondusza