Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues in http cache #2348

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Fix minor issues in http cache #2348

merged 2 commits into from
Apr 3, 2024

Conversation

dabrt
Copy link
Contributor

@dabrt dabrt commented Mar 27, 2024

Question Answer
JIRA Ticket n/a
Versions 3.3 and up
Edition all

Fix minor issues in http cache

Checklist

  • Text renders correctly

@dabrt dabrt requested a review from vidarl March 27, 2024 19:29
@dabrt
Copy link
Contributor Author

dabrt commented Mar 27, 2024

Hi @vidarl , in content_aware_cache.md, example esi_include values contain references to eZ Systems and eZ Platform. Also a number of references to eZ Systems survived in sub ez_... and call ez_... calls.

Should it stay like that? If not please suggest what we should put in there.

@dabrt dabrt requested a review from mnocon March 28, 2024 07:50
@dabrt
Copy link
Contributor Author

dabrt commented Mar 29, 2024

Hi @vidarl , in content_aware_cache.md, example esi_include values contain references to eZ Systems and eZ Platform. Also a number of references to eZ Systems survived in sub ez_... and call ez_... calls.

Should it stay like that? If not please suggest what we should put in there.

@vidarl This issue has also been identified in a parallel PR here:
ibexa/http-cache#46 (review)

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just two small suggestions

@dabrt dabrt merged commit d0241db into master Apr 3, 2024
4 checks passed
@dabrt dabrt deleted the http-cache-fix branch April 3, 2024 11:29
dabrt added a commit that referenced this pull request Apr 3, 2024
* Fix minor issues in http cache

---------

Co-authored-by: Marek Nocoń <[email protected]>
dabrt added a commit that referenced this pull request Apr 3, 2024
* Fix minor issues in http cache

---------

Co-authored-by: Marek Nocoń <[email protected]>
dabrt added a commit that referenced this pull request Apr 3, 2024
* Fix minor issues in http cache

---------

Co-authored-by: Marek Nocoń <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants