Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-6878: Customize search sorting #2226

Merged
merged 17 commits into from
Apr 19, 2024
Merged

IBX-6878: Customize search sorting #2226

merged 17 commits into from
Apr 19, 2024

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Nov 21, 2023

Question Answer
JIRA Ticket IBX-6878
Versions 4.6
Edition All

How to customize Back Office search result page's "Sort by" drop-down menu.

Install and run example:

cp -R $DOC_DIR/code_samples/back_office/search/* $DXP_DIR/
cd $DXP_DIR/                
tail -n +2 config/append_to_services.yaml >> config/services.yaml && rm config/append_to_services.yaml

Go to search page (e.g. http://localhost/admin/search?search%5Bquery%5D=user), open the sorting menu, see the "Sort by section" options.

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but overall good job 💪

@adriendupuis adriendupuis marked this pull request as ready for review February 14, 2024 12:28
Copy link
Contributor

@julitafalcondusza julitafalcondusza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

docs/administration/back_office/search_sorting.md Outdated Show resolved Hide resolved
docs/administration/back_office/search_sorting.md Outdated Show resolved Hide resolved
docs/administration/back_office/search_sorting.md Outdated Show resolved Hide resolved
docs/administration/back_office/search_sorting.md Outdated Show resolved Hide resolved
docs/administration/back_office/search_sorting.md Outdated Show resolved Hide resolved
docs/administration/back_office/search_sorting.md Outdated Show resolved Hide resolved
docs/administration/back_office/search_sorting.md Outdated Show resolved Hide resolved
Co-authored-by: julitafalcondusza <[email protected]>
Copy link
Contributor

@julitafalcondusza julitafalcondusza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.

docs/administration/back_office/search_sorting.md Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
docs/administration/back_office/search_sorting.md Outdated Show resolved Hide resolved
Co-authored-by: Tomasz Dąbrowski <[email protected]>
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adriendupuis adriendupuis merged commit 9d37154 into master Apr 19, 2024
4 checks passed
@adriendupuis adriendupuis deleted the sorting_search_php branch April 19, 2024 08:00
adriendupuis added a commit that referenced this pull request Apr 19, 2024
---------

Co-authored-by: Adrien Dupuis <[email protected]>
Co-authored-by: Adam Wójs <[email protected]>
Co-authored-by: julitafalcondusza <[email protected]>
Co-authored-by: Tomasz Dąbrowski <[email protected]>
Co-authored-by: Marek Nocoń <[email protected]>
(cherry picked from commit 9d37154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants