IBX-4929: Fix property-read usage #373
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Property* tags are used for magic properties. https://docs.phpdoc.org/guide/references/phpdoc/tags/property.html @Property* tags duplicate property definitions in the output documentation when used to re-declare real properties.
@Property* tags are used for magic properties. https://docs.phpdoc.org/guide/references/phpdoc/tags/property.html @Property* tags duplicate property definitions in the output documentation when used to re-declare real properties.
@Property* tags are used for magic properties. https://docs.phpdoc.org/guide/references/phpdoc/tags/property.html @Property* tags duplicate property definitions in the output documentation when used to re-declare real properties.
@Property* tags are used for magic properties. https://docs.phpdoc.org/guide/references/phpdoc/tags/property.html @Property* tags duplicate property definitions in the output documentation when used to re-declare real properties.
composer install; /opt/homebrew/Cellar/[email protected]/8.1.28/bin/php -d memory_limit=-1 vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.php -v --show-progress=dots;
adriendupuis
changed the title
Reorder declarations to avoid new lines from php-cs-fixer
|
|
@adriendupuis rebase is needed here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@property* tags are used for magic properties.https://docs.phpdoc.org/guide/references/phpdoc/tags/property.html
@property* tags duplicate property definitions in the output documentation when used to re-declare real properties.This is due (or partially due) to a "bug" in phpDocumentor.
protectedand declared as "magically" publicly readable thank to__get. For example,URLAliashave two$alwaysAvailableproperties:RoleDrafthas two$policiesproperties:PolicyDraftwhich is correct.Policy, inherited fromRole, which should have been overridden, and shouldn't appear.