Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-6824: Added ability to perform queries across multiple tables #8

Merged
merged 10 commits into from
Oct 31, 2023

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Oct 17, 2023

Question Answer
JIRA issue IBX-6824
Type feature
Target Ibexa version v4.6
BC breaks no

This PR allows ExpressionVisitor to "walk" queries across multiple tables.

Current hard requirement is that those tables need to be manually joined before querying. ExpressionVisitor does not perform any checks to see if the table will be reachable (although it has access to QueryBuilder object which has data about joined tables, so it is definitely possible to both implicitly join and check those eventually).

Decided to change how ExpressionVisitor picks a strategy to use. Previously the choice was made by looking up the implementation class for DoctrineRelationshipInterface. This will quickly become difficult to manage when we would mix and match different relationship options, so I opted for a specific option property/method instead.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping for example @ibexa/php-dev for back-end changes and/or @ibexa/javascript-dev for
    front-end changes).

Base automatically changed from relationship-metadata to main October 18, 2023 08:02
@Steveb-p Steveb-p force-pushed the pre-joined-relationship branch from 2c69636 to 101bb7f Compare October 18, 2023 08:03
@Steveb-p Steveb-p force-pushed the pre-joined-relationship branch from 101bb7f to 50b1807 Compare October 19, 2023 07:59
@Steveb-p Steveb-p requested review from adamwojs, alongosz, a team and mikadamczyk October 23, 2023 09:58
@Steveb-p Steveb-p added the Feature New feature request label Oct 23, 2023
@Steveb-p Steveb-p merged commit 7b81570 into main Oct 31, 2023
11 checks passed
@Steveb-p Steveb-p deleted the pre-joined-relationship branch October 31, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants