IBX-6824: Added ability to perform queries across multiple tables #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6
This PR allows
ExpressionVisitor
to "walk" queries across multiple tables.Current hard requirement is that those tables need to be manually joined before querying.
ExpressionVisitor
does not perform any checks to see if the table will be reachable (although it has access toQueryBuilder
object which has data about joined tables, so it is definitely possible to both implicitly join and check those eventually).Decided to change how
ExpressionVisitor
picks a strategy to use. Previously the choice was made by looking up the implementation class forDoctrineRelationshipInterface
. This will quickly become difficult to manage when we would mix and match different relationship options, so I opted for a specific option property/method instead.Checklist:
$ composer fix-cs
).@ibexa/php-dev
for back-end changes and/or@ibexa/javascript-dev
forfront-end changes).