Added conditional Role assign to Dashboard role #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnocon
force-pushed
the
assign-if-exists
branch
from
3a1740f to
6c8e8a9
Compare
mnocon
changed the title
mnocon
force-pushed
the
assign-if-exists
branch
3 times, most recently
from
dc01020 to
1ccaed6
Compare
mnocon
force-pushed
the
assign-if-exists
branch
from
1ccaed6 to
09ce9d6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mnocon
requested review from
micszo,
barbaragr,
katarzynazawada,
tomaszszopinski and
bogusez
tomaszszopinski
approved these changes
Nov 23, 2023
bogusez
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with https://github.com/ibexa/dashboard/pull/44
We need to let these users acces the new Dashboard - this Role is available only in the Experience and Commerce editions.
I tried adding it in the Dashboard package, but it feels like a chore - because the AdminUI, Page Builder testa are failing and we would have to amend them as well.
This conditional assignment should be easier to maintain.
Regression:
ibexa/commerce#482