Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added way of accesing the Chrome DevToolsDriver #90

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Added way of accesing the Chrome DevToolsDriver #90

merged 3 commits into from
Oct 17, 2023

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Oct 16, 2023

Lots of changes here, but they are mostly autogenerated 😉

Commits:

  1. Adds PHPStan that will be looking into our code to improve its quality 🕵️ 🐛 Also handles one issue that PHPStan was not able to handle
  2. Adds all the existing issues to the baseline - the goal is to fix them slowly, over time. This file is autogenerated by PHPStan
  3. Add a way of accesing Chrome DevTools driver from the Pages/Components - this is based on https://github.com/ibexa/visual-testing/pull/24

@mnocon mnocon force-pushed the add-devtools-driver branch from 9986d76 to 5529a78 Compare October 16, 2023 13:23
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mnocon mnocon changed the title Added devtools driver Added way of accesing the Chrome DevToolsDriver Oct 16, 2023
@mnocon mnocon mentioned this pull request Oct 16, 2023
Merged
@mnocon mnocon marked this pull request as ready for review October 16, 2023 14:55
@mnocon mnocon merged commit e9a85ca into 4.5 Oct 17, 2023
15 checks passed
@mnocon mnocon deleted the add-devtools-driver branch October 17, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@micszo micszo Awaiting requested review from micszo

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnocon @katarzynazawada @tomaszszopinski @bogusez