Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8138: [Rector] Applied rules from Symfony 5 Rector set lists #118

Merged
merged 11 commits into from
Jul 24, 2024

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jul 19, 2024

🎫 Issue IBX-8138

Description:

Applied rules from Symfony 5 Rector set lists.

For QA:

No QA needed. Regression tests should be enough.

Documentation:

This is code refactoring without behavior change. No documentation changes needed.

Applied rules:
 * AddReturnTypeDeclarationRector
 * CommandConstantReturnCodeRector
src/lib/Core/Debug/Command/GoBackCommand.php Outdated Show resolved Hide resolved
src/lib/Core/Debug/Command/RefreshPageCommand.php Outdated Show resolved Hide resolved
src/lib/Core/Debug/Command/ShowHTMLCommand.php Outdated Show resolved Hide resolved
src/lib/Core/Debug/Command/ShowURLCommand.php Outdated Show resolved Hide resolved
src/lib/Core/Debug/Command/TakeScreenshotCommand.php Outdated Show resolved Hide resolved
Copy link

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid PHPStan error.

@micszo
Copy link
Contributor

micszo commented Jul 22, 2024

@alongosz @konradoboza @Steveb-p thank you for opening and reviewing. Appreciated! 🖤

@tomaszszopinski
Copy link
Contributor

Behat should be green now, we can proceed with merge.
greenbutatwhatcost

Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved.

Copy link

sonarcloud bot commented Jul 23, 2024

@alongosz
Copy link
Member Author

Ok, it seems to be safe to merge this one now, as the changes don't affect extension points.

@alongosz alongosz merged commit de05f28 into main Jul 24, 2024
12 checks passed
@alongosz alongosz deleted the ibx-8138-symfony-5-rule-sets branch July 24, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants