-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8138: [Rector] Applied rules from Symfony 5 Rector set lists #118
Conversation
Applied rules: * AddReturnTypeDeclarationRector * CommandConstantReturnCodeRector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid PHPStan error.
@alongosz @konradoboza @Steveb-p thank you for opening and reviewing. Appreciated! 🖤 |
28338a5
to
da7e598
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved.
|
Ok, it seems to be safe to merge this one now, as the changes don't affect extension points. |
Description:
Applied rules from Symfony 5 Rector set lists.
For QA:
No QA needed. Regression tests should be enough.
Documentation:
This is code refactoring without behavior change. No documentation changes needed.