Fixes

ibexa · Oct 20, 2023 · 886bab8 · 886bab8
1 parent 46492a6
commit 886bab8
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -135,11 +135,26 @@ parameters:
 			count: 1
 			path: src/bundle/Form/RetryChoiceListFactory.php
 
+		-
+			message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Form\\\\RetryChoiceListFactory\\:\\:createListFromChoices\\(\\) has parameter \\$value with no type specified\\.$#"
+			count: 1
+			path: src/bundle/Form/RetryChoiceListFactory.php
+
+		-
+			message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Form\\\\RetryChoiceListFactory\\:\\:createListFromLoader\\(\\) has parameter \\$value with no type specified\\.$#"
+			count: 1
+			path: src/bundle/Form/RetryChoiceListFactory.php
+
 		-
 			message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Form\\\\RetryChoiceListFactory\\:\\:createView\\(\\) has parameter \\$attr with no value type specified in iterable type array\\.$#"
 			count: 1
 			path: src/bundle/Form/RetryChoiceListFactory.php
 
+		-
+			message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Form\\\\RetryChoiceListFactory\\:\\:createView\\(\\) has parameter \\$index with no type specified\\.$#"
+			count: 1
+			path: src/bundle/Form/RetryChoiceListFactory.php
+
 		-
 			message: "#^Method Ibexa\\\\Bundle\\\\Behat\\\\Form\\\\RetryChoiceListFactory\\:\\:createView\\(\\) has parameter \\$preferredChoices with no value type specified in iterable type array\\.$#"
 			count: 1

diff --git a/src/bundle/Form/RetryChoiceListFactory.php b/src/bundle/Form/RetryChoiceListFactory.php
@@ -26,7 +26,7 @@ public function __construct(ChoiceListFactoryInterface $choiceListFactory)
     }
 
     /** {@inheritDoc} */
-    public function createListFromChoices(iterable $choices, callable $value = null): ChoiceListInterface
+    public function createListFromChoices(iterable $choices, $value = null): ChoiceListInterface
     {
         $filter = \func_num_args() > 2 ? func_get_arg(2) : null;
 
@@ -36,7 +36,7 @@ public function createListFromChoices(iterable $choices, callable $value = null)
     }
 
     /** {@inheritDoc} */
-    public function createListFromLoader(ChoiceLoaderInterface $loader, callable $value = null): ChoiceListInterface
+    public function createListFromLoader(ChoiceLoaderInterface $loader, $value = null): ChoiceListInterface
     {
         $filter = \func_num_args() > 2 ? func_get_arg(2) : null;
 
@@ -50,7 +50,7 @@ public function createView(
         ChoiceListInterface $list,
         $preferredChoices = null,
         $label = null,
-        callable $index = null,
+        $index = null,
         callable $groupBy = null,
         $attr = null
     ): ChoiceListView {