Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6406: Cover "My Drafts" Page - Back-port to 4.5 #890

Merged
merged 3 commits into from
Sep 11, 2023
Merged

IBX-6406: Cover "My Drafts" Page - Back-port to 4.5 #890

merged 3 commits into from
Sep 11, 2023

Conversation

jwibexa
Copy link
Contributor

@jwibexa jwibexa commented Aug 30, 2023 •
edited
Loading

Question Answer
Tickets IBX-6406
Bug fix? no
New feature? no
BC breaks? yes/no
Tests pass? yes
Doc needed? no
License GPL-2.0

Its backport from #878
Test contains editing and deleting a draft.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

jwibexa and others added 2 commits August 30, 2023 11:44
@jwibexa
IBX-6330: [Behat] Cover "My Drafts" Page (#878)
aa8d42c 
* Initial implementation

* FInished the task of testing draft deletion

* Added the test for the edition of draft, splited the tests into 2 versions.

* cleanup

* Improvemtn of the edit table selector

* Fixes regarding editing draft selectors

* code style check fix

* Fixes regarding veryfiing deletion, style fixes, veryfiisloaded added

* Added fix regarding not finding delete confirmation, naming fix

---------

Co-authored-by: Marek Nocoń <[email protected]>
(cherry picked from commit b0e1549)
@jwibexa
Cover "My Drafts" Page
5aa6436
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jwibexa jwibexa changed the base branch from main to 4.5 August 31, 2023 11:11
@jwibexa jwibexa marked this pull request as ready for review August 31, 2023 11:13
@micszo
Copy link
Contributor

micszo commented Aug 31, 2023

Have you run regression tests against this PR already?

Please fix summary with e.g. correct format of JIRA ticket.

@micszo
Copy link
Contributor

micszo commented Aug 31, 2023

What about Behat bundle PR back-port?

mnocon
mnocon approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As Michał mentioned - a PR with backport in ibexa/behat is needed as well (and then a regression run for both of them, just to be sure)

@jwibexa jwibexa mentioned this pull request Aug 31, 2023
Merged
@jwibexa
Copy link
Contributor Author

jwibexa commented Aug 31, 2023 •
edited
Loading

Have you run regression tests against this PR already?
Here are results for the test run. I have run them locally too

Please fix summary with e.g. correct format of JIRA ticket.
Fixed

What about Behat bundle PR back-port?
ibexa/behat#75

@jwibexa jwibexa mentioned this pull request Aug 31, 2023
Closed
@micszo
Copy link
Contributor

micszo commented Aug 31, 2023

This is the summary. 🙂

Screenshot 2023-08-31 at 15 24 39

@jwibexa jwibexa changed the title Ibx 6406 my draft page back port 4.5 IBX-6406 Cover "My Drafts" Page - Back-port to 4.5 Aug 31, 2023
@adamwojs adamwojs changed the title IBX-6406 Cover "My Drafts" Page - Back-port to 4.5 IBX-6406: Cover "My Drafts" Page - Back-port to 4.5 Sep 1, 2023
@micszo micszo merged commit 8bf80ee into 4.5 Sep 11, 2023
15 checks passed
@micszo micszo deleted the IBX-6406-My-Draft-Page-Back-port-4.5 branch September 11, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@mnocon mnocon mnocon approved these changes

@micszo micszo Awaiting requested review from micszo

@tomaszszopinski tomaszszopinski Awaiting requested review from tomaszszopinski

@krzbro krzbro Awaiting requested review from krzbro

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jwibexa @micszo @mnocon @katarzynazawada @bogusez @mikadamczyk @Nattfarinn @ciastektk @ViniTou