Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin): add plugin isYesterday #1982

Merged
merged 2 commits into from
Jul 13, 2022
Merged

feat(plugin): add plugin isYesterday #1982

merged 2 commits into from
Jul 13, 2022

Conversation

BePo65
Copy link
Contributor

@BePo65 BePo65 commented Jul 9, 2022 •
edited
Loading

feat: add plugin isYesterday to dayjs 2.0.

Fix changes recommended by eslint.

@BePo65
Copy link
Contributor Author

BePo65 commented Jul 9, 2022

Regarding the error in the ci checks, see my comment in issue #1879.

As I base my pr on the latest commit of 'next', shouldn't the checks run without problem? Any help appreciated.

@BePo65 BePo65 force-pushed the pu2.0/plugin/isYesterday branch 2 times, most recently from 2ac0916 to 09d3982 Compare July 12, 2022 05:20
sxzz
sxzz reviewed Jul 12, 2022
View reviewed changes
src/plugin/isYesterday.ts Outdated Show resolved Hide resolved
@sxzz sxzz force-pushed the pu2.0/plugin/isYesterday branch from 8ada96e to ddd7a26 Compare July 13, 2022 17:43
@sxzz sxzz changed the title dayjs 2.0 - add plugin isYesterday feat(plugin): add plugin isYesterday Jul 13, 2022
@sxzz sxzz merged commit f33d327 into iamkun:next Jul 13, 2022
@BePo65 BePo65 deleted the pu2.0/plugin/isYesterday branch July 14, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BePo65 @sxzz