fix device override in model.py #28
Open
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guangyaodou thanks for the PR. Just to make sure- everything works as expected for Llama with this fix, right? Can you try it once |
|
@iamgroot42 Hi. I just tried it and it will only prevent overriding my device for Llama models. With this being said, I think one should also change device_map in this line to device_map (which is not included in this PR). Also, based on the discussion in this post, Llama3 now uses different tokenizer and should only be initialized with AutoTokenizer. This means that initialization of Llama model should also be changed to Autotokenizer. Please let me know if you want me to include these changes in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed device override when loading Llama models.