Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post "Manage fork repository locally and remotely" article #44

Merged
merged 13 commits into from
Jun 10, 2024

Conversation

ZynoXelek
Copy link
Contributor

@ZynoXelek ZynoXelek commented Apr 16, 2024

This article aims to explain how to :

  • Create a fork
  • Work with a fork
  • Pull request on the original repository

@ZynoXelek ZynoXelek marked this pull request as draft April 16, 2024 15:18
@ctmbl
Copy link
Contributor

ctmbl commented Apr 16, 2024

Great draft really!!
Of course, I know, it's a draft 🙂

some temporary comments (more to my future self than you) until I find some time to continue your wonderful job:

  • git add before git commit (might be interesting to put some git status or/and git log --all --graph --oneline --decorate)
  • add a link to GitHub - Create a SSH key and GitHub - add a new SSH key when introducing clone-ning and pushing
  • it's far better to pull request before finishing your code (at the end of the first session for example) than waiting for the end of the development/writing of a feature, I'll never say it enough I guess 🥲
  • at the end to update your local fork -> to update your local copy: strictly speaking we don't know if you cloned a fork or not, when speaking about cloned repositories we don't use such naming
  • some typos:
    • now -> know
    • at the beginning when enumerating: committing -> commit other verbs too (use infinitive not +ing

@ctmbl ctmbl requested review from ctmbl and removed request for ctmbl April 30, 2024 22:22
@ctmbl ctmbl added the new content Add new posts, resources, events, or any content label Apr 30, 2024
@ctmbl ctmbl marked this pull request as ready for review June 7, 2024 17:15
@ctmbl
Copy link
Contributor

ctmbl commented Jun 7, 2024

I just reviewed it @ZynoXelek great article indeed!!

Just 2 things beofre the merge:

  • could you write a brief conclusion?
  • could you either:
    • add a summary
    • remove the summary attribute from the header and an auto generated summary will be displayed (basically the first 60 characters of the article)
    • remove the summary attribute and put this line somewhere to explicitely "cut" the summary

@ctmbl ctmbl merged commit ec610b9 into iScsc:main Jun 10, 2024
4 of 5 checks passed
@ZynoXelek ZynoXelek deleted the Fork-Article branch June 10, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new content Add new posts, resources, events, or any content Priority - High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants