Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post : Online Game Article #30

Merged
merged 23 commits into from
Mar 30, 2024

Conversation

ZynoXelek
Copy link
Contributor

@ZynoXelek ZynoXelek commented Feb 28, 2024

An article to explain how we made a multiplayer online game and what we learnt while doing it.

First version.

@ZynoXelek ZynoXelek changed the title Online Game Article (Draft) Add blog post : Online Game Article (Draft) Feb 28, 2024
@ctmbl ctmbl marked this pull request as draft February 28, 2024 22:48
@ctmbl ctmbl changed the title Add blog post : Online Game Article (Draft) Add blog post : Online Game Article Feb 28, 2024
@ZynoXelek ZynoXelek marked this pull request as ready for review March 11, 2024 15:39
@ZynoXelek ZynoXelek requested review from ctmbl and Laudut March 11, 2024 15:40
@ZynoXelek
Copy link
Contributor Author

I'd like to add @BlueNZ and @Shisohka as reviewers as they worked on the server with me but it seems I can't.

@ZynoXelek ZynoXelek requested review from Shisohka, ctmbl and BlueNZ and removed request for ctmbl March 18, 2024 16:03
@ZynoXelek
Copy link
Contributor Author

I'd like to add @BlueNZ and @Shisohka as reviewers as they worked on the server with me but it seems I can't.

Now that you are in the ISCSC organization, I could successfully request your reviews @Shisohka @BlueNZ !

Copy link
Contributor

@ctmbl ctmbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great post! Thanks a lot for taking the time to write it, I'm certain this will be useful in the future for you, for others or simply if someone wants to go on with the project. In any case I'm sure you learnt all a lot taking on this project and also writing this post!

I have a couple of remarks to make but nothing big:

  • the only important one is to add a header, I address it with this thread below: Add blog post : Online Game Article #30 (comment)
  • I made a few suggestions when I saw some spelling mistakes, you can commit them with the Commit sugestion button directly on GitHub
  • the post is quite long, a table of content and a conclusion would help a lot I think 🙂
  • in English there is no whitespaces before question and exclamation mark: end ! -> end!, same for ?
  • I suggested it once (Add blog post : Online Game Article #30 (comment)) but do it for all of them: you can trigger syntax highlight for python in your code block using the keyword py added to the first triple backstick:
\```py (without the antislash of course)
python code here
\```

this helps a LOT the reading of code blocks

And that's all! Tks a lot again for your post!

src/content/posts/multiplayer_online_game.md Outdated Show resolved Hide resolved
src/content/posts/multiplayer_online_game.md Outdated Show resolved Hide resolved
src/content/posts/multiplayer_online_game.md Show resolved Hide resolved
src/content/posts/multiplayer_online_game.md Outdated Show resolved Hide resolved
src/content/posts/multiplayer_online_game.md Outdated Show resolved Hide resolved
src/content/posts/multiplayer_online_game.md Outdated Show resolved Hide resolved
src/content/posts/multiplayer_online_game.md Show resolved Hide resolved
src/content/posts/multiplayer_online_game.md Outdated Show resolved Hide resolved
src/content/posts/multiplayer_online_game.md Outdated Show resolved Hide resolved
src/content/posts/multiplayer_online_game.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ctmbl ctmbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less comments than last time clearly, I think it's almost ready for publishing!

src/content/posts/multiplayer_online_game.md Show resolved Hide resolved
src/content/posts/multiplayer_online_game.md Show resolved Hide resolved
src/content/posts/multiplayer_online_game.md Outdated Show resolved Hide resolved
src/content/posts/multiplayer_online_game.md Outdated Show resolved Hide resolved
src/content/posts/multiplayer_online_game.md Outdated Show resolved Hide resolved
Copy link

@BlueNZ BlueNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very complete work.

Copy link
Contributor

@ctmbl ctmbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZynoXelek This post seems nice feel free to merge the PR via the "Squash and merge" button 😉

@ZynoXelek ZynoXelek merged commit 0bd69d3 into iScsc:main Mar 30, 2024
4 checks passed
@ZynoXelek ZynoXelek deleted the Online-Game-Article branch March 30, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants