Skip to content

Commit

Permalink
Add "pull request sooner" paragraph
Browse files Browse the repository at this point in the history
  • Loading branch information
ZynoXelek committed Apr 24, 2024
1 parent 1f159f9 commit cb17f14
Showing 1 changed file with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,13 @@ When it is done, simply go on the origin repository github page, and you will ha

[Insert image here]

In fact, you should definitely pull request **before** finishing your code. It helps with your work's transparency, but it also allow to receive feedback sooner, which could prevent working several hours on something that is wrong from scratch. You will be able to change your code immediately and it could prevent a lot of frustration on your side.
Similarly, when working on open source repositories, the owner have the complete right to refuse your change, even if you think your change is right and legitimate. Knowing that it will be refused whatsoever after working an hour on it is definitely easier to accept than after working weeks on your code.

And don't worry, you will be able to keep working on your code even after pull-requesting. You only have to mark your PR as a draft to tell your reviewers you are still working on it by clicking there :

[Insert image here]

## Update your fork

Once your pull request have been accepted on the remote origin repository, you may update your fork to the new state of the origin repository.
Expand Down

0 comments on commit cb17f14

Please sign in to comment.