Isolate bot channel #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctmbl
force-pushed
the
isolate-bot-channel
branch
from
78ad845 to
5397df6
Compare
ctmbl
force-pushed
the
isolate-bot-channel
branch
from
5397df6 to
d1613c3
Compare
ctmbl
force-pushed
the
isolate-bot-channel
branch
from
d5c94cd to
924bcd6
Compare
ZynoXelek
reviewed
Oct 26, 2023
ZynoXelek
reviewed
Oct 26, 2023
ZynoXelek
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a little global check in
root_pythia_bot.pythat prevents the bot to respond in another channel than the one it is assign to.This is really annoying when a development instance is up to have both bots (production and development) respondoing to every command, it can also mess with the prod bot DB.
The global check returns false if the context channel (the one form which the command is triggered) ID is different from CHANNEL_ID (the channel where the bot ping on new solves), making the command to be aborted, raisign an exception caught in
on_command_errorand ignored after logging a warningTODO: this could be cool to make this behavior configurable in .env or other configuration (even dynamic with some bot API?)