Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Frankfurt Flugh, Frankfurt Main and Siegburg (d) #25

Merged
merged 2 commits into from
Jul 18, 2015
Merged

Added Frankfurt Flugh, Frankfurt Main and Siegburg (d) #25

merged 2 commits into from
Jul 18, 2015

Conversation

brechtvdv
Copy link
Contributor

Fixes #24

@brechtvdv brechtvdv changed the title Added Frankfurt Flugh, Frankfurt Main and Siegburg (d) Added Frankfurt Flugh, Frankfurt Main and Siegburg (d) #24 May 29, 2015
@brechtvdv brechtvdv changed the title Added Frankfurt Flugh, Frankfurt Main and Siegburg (d) #24 Added Frankfurt Flugh, Frankfurt Main and Siegburg (d) May 29, 2015
@pietercolpaert
Copy link
Member

Frankfurt main conflicts with Frankfurt am main?

@pietercolpaert
Copy link
Member

Currently there's no way of adding alternative names, next to adding different names in different languages. How did you encounter Frankfurt Main?

@pietercolpaert
Copy link
Member

Also, Frankfurt Flugh and Frankfurt am mein Flughaven are the same thing indeed. Should we add a new column to add an alternative, not preferred, name?

Also see the discussion at #13

@brechtvdv
Copy link
Contributor Author

I encountered it with http://api.irail.be/vehicle/?id=ice10&fast=false&lang=en .(there's index-bug in it that I've fixed in iRail/iRail#66)

I'll delete Frankfurt Flugh and Frankfurt main because of duplication.

@brechtvdv
Copy link
Contributor Author

Can you merge this, so Siegburg is added?

@brechtvdv
Copy link
Contributor Author

Need the station for the completion of the GTFS-files ;)

Tuinslak added a commit that referenced this pull request Jul 18, 2015
@Tuinslak
Merge pull request #25 from brechtvdv/master
5230ea4 
Added Frankfurt Flugh, Frankfurt Main and Siegburg (d)
@Tuinslak Tuinslak merged commit 5230ea4 into iRail:master Jul 18, 2015
@Tuinslak
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some German stations
3 participants
@brechtvdv @pietercolpaert @Tuinslak